feat: add support for --help and version commands in aks-node-controller#8313
Merged
feat: add support for --help and version commands in aks-node-controller#8313
Conversation
Devinwong
requested review from
AbelHu,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds user-facing --help/help and --version/version handling to aks-node-controller so informational invocations exit cleanly without emitting normal startup logging.
Changes:
- Add early argument handling in
App.Runfor--help/helpand--version/version. - Remove the previous in-command
versionhandling fromrun. - Add tests to assert
--helpandhelpreturn success exit codes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| aks-node-controller/app.go | Adds a centralized handleInfoCommand pre-dispatch handler for help/version output and exit codes. |
| aks-node-controller/app_test.go | Adds basic tests verifying --help and help exit with code 0. |
awesomenix
approved these changes
Apr 15, 2026
Collaborator
Author
|
Test_ACL_Scriptless and Test_ACL_AzureCNI_ChronyRestarts_Scriptless also failed in other PR and are unrelated to this PR changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add support for --help and version commands in aks-node-controller
Which issue(s) this PR fixes:
Fixes #