fix: windows doesnt support EnableScriptlessCSECmd which is default now#8318
Merged
awesomenix merged 1 commit intomainfrom Apr 15, 2026
Merged
fix: windows doesnt support EnableScriptlessCSECmd which is default now#8318awesomenix merged 1 commit intomainfrom
awesomenix merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates e2e validation logic to skip Scriptless CSE checks for Windows distros, since Windows does not support EnableScriptlessCSECmd and the current default causes false failures.
Changes:
- Skip “scriptless CSE customData has no scripts” validation on Windows in VMSS model creation.
- Skip “scriptless CSE overrides file exists” validation on Windows nodes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| e2e/vmss.go | Avoids running Linux-specific scriptless CSE customData validation on Windows. |
| e2e/validators.go | Avoids checking for a Linux-only file path on Windows during scriptless CSE validation. |
timmy-wright
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows doesnt support EnableScriptlessCSECmd, fix it properly later