fix: move EnableScriptlessNBCCSECmd to ScenarioRuntime#8325
Merged
awesomenix merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
awesomenix
requested review from
AbelHu,
Devinwong,
SriHarsha001,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
r2k1
approved these changes
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the E2E “scriptless NBC CSE cmd” toggle from the scenario definition into per-run runtime state (ScenarioRuntime), adjusting the scenario runner to support setting this runtime flag before executing the scenario.
Changes:
- Remove
EnableScriptlessNBCCSECmdfromScenarioand add it toScenarioRuntime. - Update
RunScenarioto no longer return an error and to set the runtime flag for thescriptless_nbcsubtest viaScenarioRuntime. - Adjust
runScenarioruntime initialization to preserve an existingScenarioRuntime(so pre-set runtime flags are not overwritten).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| e2e/types.go | Moves EnableScriptlessNBCCSECmd from Scenario into ScenarioRuntime. |
| e2e/test_helpers.go | Updates scenario execution flow to set/read the scriptless-NBC toggle via ScenarioRuntime and simplifies RunScenario signature. |
awesomenix
force-pushed
the
nishp/multiplescenario
branch
from
889eedd to
1192186
Compare
Devinwong
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up PR to address comments from previous