Skip to content

test: reduce Go test timeout to 80m to stay below 90m ADO job limit#8395

Merged
djsly merged 1 commit intomainfrom
fix/e2e-go-test-timeout-below-ado
Apr 24, 2026
Merged

test: reduce Go test timeout to 80m to stay below 90m ADO job limit#8395
djsly merged 1 commit intomainfrom
fix/e2e-go-test-timeout-below-ado

Conversation

@r2k1
Copy link
Copy Markdown
Contributor

@r2k1 r2k1 commented Apr 24, 2026

Problem

The Go test timeout (E2E_GO_TEST_TIMEOUT=90m) equals the ADO job timeout (timeoutInMinutes: 90), leaving zero buffer.

ADO kills the job before Go can finish, resulting in:

  • No test output (gotestsum buffers until completion)
  • Silent failures with no actionable diagnostics
  • 0-byte scenario log artifacts

Fix

Reduce default Go test timeout from 90m → 80m, giving 10 minutes of buffer for Go to finish, flush results, and upload artifacts before ADO cancels.

Impact

  • E2E tests that exceed 80m will now fail with a proper Go timeout error and produce test output, instead of being silently killed by ADO
  • No functional change to tests that complete within 80m

The Go test timeout (90m) was equal to the ADO job timeout (90m),
leaving zero buffer. When tests take the full duration, ADO kills the
job before Go can finish, resulting in no test output and silent
failures (e.g. windows-23H2-gen2 in build 161489045).

Reducing to 80m ensures Go finishes and flushes test results before
ADO cancels the job, giving 10 minutes of buffer for cleanup and
artifact upload.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the default Go E2E test timeout used by the Azure DevOps pipeline runner script so the test process terminates and flushes results before the 90-minute job timeout kills the agent, improving debuggability and artifact reliability.

Changes:

  • Reduce default E2E_GO_TEST_TIMEOUT from 90m to 80m in the E2E pipeline run script.

@r2k1 r2k1 changed the title fix(e2e): reduce Go test timeout to 80m to stay below 90m ADO job limit test: reduce Go test timeout to 80m to stay below 90m ADO job limit Apr 24, 2026
@r2k1 r2k1 enabled auto-merge (squash) April 24, 2026 04:06
@rchincha rchincha requested a review from Copilot April 24, 2026 06:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@djsly djsly disabled auto-merge April 24, 2026 11:54
@djsly djsly merged commit 54aa84a into main Apr 24, 2026
47 of 53 checks passed
@djsly djsly deleted the fix/e2e-go-test-timeout-below-ado branch April 24, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants