chore: remove snapshot generation from copilot-instructions.md#8415
Merged
cameronmeissner merged 1 commit intomainfrom Apr 28, 2026
Merged
chore: remove snapshot generation from copilot-instructions.md#8415cameronmeissner merged 1 commit intomainfrom
cameronmeissner merged 1 commit intomainfrom
Conversation
cameronmeissner
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Removes outdated “run make generate to regenerate snapshot test data” guidance from the repository’s Copilot instruction prompt, aligning the prompt with the claimed removal of snapshot/testdata workflows.
Changes:
- Deleted the snapshot/testdata regeneration instruction from
.github/copilot-instructions.md.
Comment on lines
26
to
28
| [parts](./parts/) serves both AgentBaker Service and VHD build. AgentBaker service and VHDs are coupled because of this shared component. When building VHD, packer maps and renames scripts from [parts](./parts/) depending on the OS / versions. The mappings can be found at [packer](./vhdbuilder/packer/). | ||
|
|
||
| > **IMPORTANT**: When making changes to files in the `parts` or `pkg` directories, you must run `make generate` afterward to regenerate the snapshot test data. This ensures consistency between the code and tests and prevents regressions. | ||
|
|
||
| Windows uses a different folder [cse](./staging/cse/windows/) for almost the same purpose. There are subtle differences as windows CSEs can be downloaded as a zip file during provisioning time due to restrictions on the file size on Windows system, while for linux based systems the cse/custom data are dropped in during provisioning time. |
There was a problem hiding this comment.
This change removes the snapshot/testdata guidance here, but the same instruction still exists in other repo guidance (e.g., custom-instructions/repo/.github/copilot-instructions.md, README.md, AGENTS.md). If snapshot testdata is truly gone, those references should be updated too; otherwise Copilot/user-facing docs will be inconsistent and the PR may not fully achieve its stated goal (removing it from the Copilot base prompt).
r2k1
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
removes snapshot generation instructions from copilot base prompt since we no longer have snapshots/testdata
Which issue(s) this PR fixes:
Fixes #