fix: dont run scriptless phase2 if preprovision is turned on#8440
Merged
awesomenix merged 1 commit intomainfrom May 1, 2026
Merged
fix: dont run scriptless phase2 if preprovision is turned on#8440awesomenix merged 1 commit intomainfrom
awesomenix merged 1 commit intomainfrom
Conversation
awesomenix
requested review from
AbelHu,
Devinwong,
SriHarsha001,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Disables scriptless NBC “phase 2” behavior when pre-provisioning mode (PreProvisionOnly) is enabled, to avoid running the scriptless provisioning flow during image-capture scenarios.
Changes:
- Guarded scriptless NBC customData payload generation behind
!PreProvisionOnly. - Updated e2e VMSS creation to skip the NBC cmd hack path when
PreProvisionOnlyis set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/agent/baker.go | Prevents scriptless NBC boothook/ignition customData generation when preprovisioning-only mode is enabled. |
| e2e/vmss.go | Skips injecting/running the scriptless NBC cmd hack during VMSS creation when preprovisioning-only mode is enabled. |
awesomenix
force-pushed
the
nishp/cleanup/gputests
branch
from
e77eecd to
1d7653e
Compare
awesomenix
force-pushed
the
nishp/cleanup/gputests
branch
from
1d7653e to
ed2f5ed
Compare
r2k1
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable phase 2 provisioning if preprovision is on