fix: add agentbaker tests for new code path i added#8473
Merged
Conversation
awesomenix
requested review from
AbelHu,
Devinwong,
SriHarsha001,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Ginkgo tests in pkg/agent/baker_test.go to validate that scriptless Linux custom data includes (or omits) the init-aks-custom-cloud.sh write_files entry when running in AKS custom cloud scenarios.
Changes:
- Added new unit tests asserting
initAKSCustomCloudFilepathis present in scriptless custom data for AKS custom cloud configurations (Ubuntu and Azure Linux). - Added coverage for a USSec location variant and a negative case for non-custom-cloud configs.
Comment on lines
+1491
to
+1496
| It("should render initAKSCustomCloud file in scriptless custom data for default cloud with Ubuntu", func() { | ||
| templateGenerator := InitializeTemplateGenerator() | ||
| config := newConfig(false) | ||
| config.ContainerService.Properties.CustomCloudEnv = &datamodel.CustomCloudEnv{ | ||
| Name: "akscustom", | ||
| } |
Comment on lines
+1507
to
+1513
| It("should render initAKSCustomCloud file in scriptless custom data for default cloud with AzureLinux", func() { | ||
| templateGenerator := InitializeTemplateGenerator() | ||
| config := newConfig(false) | ||
| config.ContainerService.Properties.CustomCloudEnv = &datamodel.CustomCloudEnv{ | ||
| Name: "akscustom", | ||
| } | ||
| config.AgentPoolProfile.Distro = datamodel.AKSAzureLinuxV2 |
Comment on lines
+1524
to
+1538
| It("should render initAKSCustomCloud file in scriptless custom data for USSecCloud with Ubuntu", func() { | ||
| templateGenerator := InitializeTemplateGenerator() | ||
| config := newConfig(false) | ||
| config.ContainerService.Properties.CustomCloudEnv = &datamodel.CustomCloudEnv{ | ||
| Name: "akscustom", | ||
| } | ||
| config.ContainerService.Location = "usseceast" | ||
|
|
||
| renderConfig := *config | ||
| renderConfig.EnableScriptlessCSECmd = true | ||
| nodeCustomData := getCustomDataFromJSON(templateGenerator.getLinuxNodeCustomDataJSONObject(&renderConfig)) | ||
|
|
||
| Expect(nodeCustomData).To(ContainSubstring(initAKSCustomCloudFilepath)) | ||
| Expect(nodeCustomData).To(ContainSubstring("permissions: \"0744\"")) | ||
| Expect(nodeCustomData).To(ContainSubstring("encoding: gzip")) |
cameronmeissner
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add tests for code i newly added