fix: remove description while writing out mod file#8485
Merged
Conversation
awesomenix
requested review from
AbelHu,
Devinwong,
SriHarsha001,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the human-readable description/comment line from the generated /etc/modprobe.d/disable-<module>.conf files written by disableVulnerableKernelModule() in the Linux CSE (cse_main.sh), and updates the corresponding ShellSpec test to match.
Changes:
- Update
disableVulnerableKernelModule()to write only theinstall ... /bin/falseandblacklist ...directives (no leading# <description>line). - Adjust ShellSpec expectations to stop asserting the CVE description is present in the generated modprobe config.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| parts/linux/cloud-init/artifacts/cse_main.sh | Removes writing the description comment into the modprobe.d config while keeping the functional directives. |
| spec/parts/linux/cloud-init/artifacts/cse_main_disable_modules_spec.sh | Updates unit test to no longer expect the CVE string in the generated config file. |
Collaborator
|
In check-in gate e2e, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hotfix