fix: prewarm containerd, increase timeout value for wait for containerd ready#8496
Merged
Conversation
awesomenix
requested review from
AbelHu,
Devinwong,
SriHarsha001,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce containerd-related startup delays during Linux node provisioning by (1) pre-warming containerd early in basePrep() and (2) increasing the retry window in waitForContainerdReady() to better match observed production timings.
Changes:
- Add a background “pre-warm” invocation of containerd version output in
basePrep(). - Increase
waitForContainerdReady()retry attempts from 120 to 240 (0.1s sleep) to allow up to ~24s for readiness.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| parts/linux/cloud-init/artifacts/cse_main.sh | Adds a background containerd version call intended to pre-warm containerd. |
| parts/linux/cloud-init/artifacts/cse_helpers.sh | Extends containerd readiness wait window by increasing retry count. |
| setupCNIDirs | ||
|
|
||
| # pre-warm containerd by checking its version. | ||
| nohup /bin/sh -c '/usr/bin/containerd --version >/dev/null 2>&1' >/dev/null 2>&1 & |
ganeshkumarashok
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed in production, containerd can take upto 21s and in E2E at minimum it takes 5s, speed everything up.