fix: better logging when file hash compare fails#8503
Merged
Conversation
timmy-wright
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows VHD content validation PowerShell script used by the VHD builder test pipeline, aiming to improve diagnostics when cached file hash comparisons fail.
Changes:
- Reformats multiple PowerShell function/loop blocks to use a consistent brace style.
- Enhances the hash-mismatch error output in
Test-FilesToCacheOnVHDto include more context.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
vhdbuilder/packer/test/windows-vhd-content-test.ps1:200
- Same issue as above: in the
catchpath$invalidFilesis overwritten ($invalidFiles = $mcURL) instead of appended, which can hide other invalid files discovered earlier in the run.
catch {
Write-ErrorWithTimestamp "$mcURL is invalid"
$invalidFiles = $mcURL
continue
djsly
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #