fix: fix delete cached kube binaries#8533
Merged
Merged
Conversation
lilypan26
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes cleanup of cached kube binaries during Linux node provisioning by allowing the shell glob to expand when removing stale /opt/bin/<package>-* files after a fallback binary install.
Changes:
- Updates
fallbackToKubeBinaryInstallincse_helpers.shso cached kube binary cleanup matches versioned files correctly.
| chown root:root "${targetPath}" | ||
| chmod 0755 "${targetPath}" | ||
| rm -rf "/opt/bin/${packageName}-*" & | ||
| rm -rf /opt/bin/"${packageName}"-* & |
Collaborator
|
Could you also take care of this issue? |
awesomenix
approved these changes
May 18, 2026
Devinwong
reviewed
May 18, 2026
awesomenix
approved these changes
May 18, 2026
|
|
||
| rm -rf "${downloadDir}" | ||
| # Clean up stale cached binaries that were not used | ||
| rm -f /opt/bin/"${packageName}"-* & |
| logs_to_events "AKS.CSE.install${packageName}.extractBinaryFromRPM" "extractBinaryFromRPM ${rpmFile} ${packageName} ${targetPath}" || exit "$ERR_APT_INSTALL_TIMEOUT" | ||
| rm -rf "${downloadDir}" | ||
| # Clean up stale cached binaries that were not used | ||
| rm -f /opt/bin/"${packageName}"-* & |
|
|
||
| # All tools installed successfully | ||
| rm -rf "${download_root}" | ||
| rm -f /opt/bin/"${tool_name}"-* & |
| chown root:root "${targetPath}" | ||
| chmod 0755 "${targetPath}" | ||
| rm -rf "/opt/bin/${packageName}-*" & | ||
| rm -rf /opt/bin/"${packageName}"-* & |
| rpm2cpio "${rpmFile}" | cpio -i --to-stdout "./usr/bin/${packageName}" "./usr/local/bin/${packageName}" | install -m0755 /dev/stdin "${targetPath}" | ||
| rm -rf "${downloadDir}" | ||
| # Clean up stale cached binaries that were not used | ||
| rm -f /opt/bin/"${packageName}"-* & |
Devinwong
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #