chore: clean up acl and flatcar kube binaries#8543
Merged
Conversation
lilypan26
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Flatcar and ACL cloud-init install scripts to clean up stale version-suffixed kubelet/kubectl binaries after successfully installing the sysext-based kube binaries, helping keep /opt/bin tidy and avoid confusion from unused cached versions.
Changes:
- Add a cleanup step to remove
/opt/bin/kubelet-*and/opt/bin/kubectl-*after successfulmergeSysexts+ symlink creation (Flatcar + ACL). - Run the cleanup in the background (
&) to avoid blocking the install path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| parts/linux/cloud-init/artifacts/flatcar/cse_install_flatcar.sh | Adds background cleanup of version-suffixed kube binaries after successful sysext install. |
| parts/linux/cloud-init/artifacts/acl/cse_install_acl.sh | Adds the same background cleanup behavior for ACL sysext installs. |
Comment on lines
+84
to
+85
| # Clean up stale cached binaries that were not used | ||
| rm -f /opt/bin/kubelet-* /opt/bin/kubectl-* & |
Comment on lines
+99
to
+100
| # Clean up stale cached binaries that were not used | ||
| rm -f /opt/bin/kubelet-* /opt/bin/kubectl-* & |
awesomenix
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #