Bug fix: Provider should continue to refresh when previous refresh operation didn't complete #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CsCherrYY
approved these changes
Sep 10, 2025
zhiyuanliang-ms
added a commit
that referenced
this pull request
Sep 10, 2025
* Merge pull request #226 from Azure/dependabot/npm_and_yarn/vite-7.1.5 Bump vite from 7.1.4 to 7.1.5 * Bug fix: Provider should continue to refresh when previous refresh operation didn't complete (#225) * fix refresh all failure bug * add testcase --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Sentinel key refresh scenario:
refresh()is called, provider will first send a watch request to check whether sentinel key(i.e. watched setting) is changedThe previous bug is that if the last refresh operation failed in step 2, the following refresh call will not continue to reload keyvalues until sentinel key is changed again.