Do not reload all watched settings when a refresh all is trigger #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CsCherrYY
approved these changes
Sep 10, 2025
zhiyuanliang-ms
deleted the
zhiyuanliang/not-reload-all-watched-setting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
When sentinel key is watched for refresh,
If we detect any sentinel key is changed, the provider will reload all selected kvs. Previously, it will also reload all watched settings, this behavior is same as .NET provider. However, as #93 said, .NET provider will also serve watched settings in the configuration, but other providers don't have this behavior. So there is no need to reload all watched settings, since it may cause side effect that we will miss a refresh.
For example,
there are two sentinel keys: key1 and key2
When key1 is changed, we trigger a refresh-all, during the refresh-all, key2 is changed, we reload it. This signal will miss for next refresh call.