Skip to content

Clean up the old Azure Functions examples#1029

Merged
zhenlan merged 1 commit intomainfrom
cleanup
Mar 19, 2025
Merged

Clean up the old Azure Functions examples#1029
zhenlan merged 1 commit intomainfrom
cleanup

Conversation

@zhenlan
Copy link
Copy Markdown
Member

@zhenlan zhenlan commented Mar 18, 2025

@zhenlan zhenlan requested a review from Copilot March 18, 2025 02:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request cleans up outdated Azure Functions examples by removing deprecated example files and updating the remaining ones to demonstrate the new async feature evaluation with CancellationToken support. Key changes include:

  • Updating the examples to pass CancellationToken (req.HttpContext.RequestAborted) to async feature evaluations.
  • Removing all legacy Azure Functions examples (in-process, out-of-process, etc.) that are no longer maintained.
  • Revising the README file to reflect the new examples and updated folder structure.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

File Description
examples/README.md Updated headings, links, and descriptions for new examples.
examples/DotNetCore/AzureFunctions/FunctionAppIsolated/ShowBetaFeature.cs Updated IsEnabledAsync call to include CancellationToken.
examples/DotNetCore/AzureFunctions/FunctionAppInProcess/ShowBetaFeature.cs Updated IsEnabledAsync call to include CancellationToken.
Other files in examples/DotNetCore/AzureFunction/* Entirely removed legacy Azure Functions examples.
Comments suppressed due to low confidence (2)

examples/README.md:5

  • [nitpick] Verify that the folder naming convention ('AzureFunctions' vs. 'AzureFunction') is consistent across the documentation and project directories to avoid potential confusion.
### [Azure Functions (Isolated worker model)](./DotNetCore/AzureFunctions/FunctionAppIsolated)

examples/README.md:9

  • [nitpick] Ensure that the naming and descriptions for the in-process example are aligned with the updated structure and clearly distinguish between isolated and in-process models.
### [Azure Functions (In-process model)](./DotNetCore/AzureFunctions/FunctionAppInProcess)

@zhenlan zhenlan merged commit acbbf3c into main Mar 19, 2025
6 checks passed
@zhenlan zhenlan deleted the cleanup branch May 21, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants