Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request cleans up outdated Azure Functions examples by removing deprecated example files and updating the remaining ones to demonstrate the new async feature evaluation with CancellationToken support. Key changes include:
- Updating the examples to pass CancellationToken (req.HttpContext.RequestAborted) to async feature evaluations.
- Removing all legacy Azure Functions examples (in-process, out-of-process, etc.) that are no longer maintained.
- Revising the README file to reflect the new examples and updated folder structure.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/README.md | Updated headings, links, and descriptions for new examples. |
| examples/DotNetCore/AzureFunctions/FunctionAppIsolated/ShowBetaFeature.cs | Updated IsEnabledAsync call to include CancellationToken. |
| examples/DotNetCore/AzureFunctions/FunctionAppInProcess/ShowBetaFeature.cs | Updated IsEnabledAsync call to include CancellationToken. |
| Other files in examples/DotNetCore/AzureFunction/* | Entirely removed legacy Azure Functions examples. |
Comments suppressed due to low confidence (2)
examples/README.md:5
- [nitpick] Verify that the folder naming convention ('AzureFunctions' vs. 'AzureFunction') is consistent across the documentation and project directories to avoid potential confusion.
### [Azure Functions (Isolated worker model)](./DotNetCore/AzureFunctions/FunctionAppIsolated)
examples/README.md:9
- [nitpick] Ensure that the naming and descriptions for the in-process example are aligned with the updated structure and clearly distinguish between isolated and in-process models.
### [Azure Functions (In-process model)](./DotNetCore/AzureFunctions/FunctionAppInProcess)
juniwang
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CancellationTokenfor async feature evaluation, showcasing a new feature added in the latest feature management release.