Skip to content

PSFMessage level update#568

Merged
Jefajers merged 6 commits intoAzure:mainfrom
Jefajers:Json-Scope-Warnings
Mar 1, 2022
Merged

PSFMessage level update#568
Jefajers merged 6 commits intoAzure:mainfrom
Jefajers:Json-Scope-Warnings

Conversation

@Jefajers
Copy link
Copy Markdown
Member

@Jefajers Jefajers commented Feb 25, 2022

Overview/Summary

This PR updates PSFMessage level from warning to debug during try/catch deployment and deletion list creation in Invoke-AzOpsPush.ps1.

The result makes the standard output of a AzOps push run cleaner and still allows for detailed step by step logging if required.

An error during deployment and deletion list creation is not deemed as a terminating error that stops all other processing since there can be other objects that are processed successfully.

Closes #338

This PR fixes/adds/changes/removes

  1. Changes PSFMessage -Level from Warning to Debug during deployment and list creation try/catch.
  2. Removes unnecessary code section after try/catch.
  3. Removes unnecessary error codes from strings.

Breaking Changes

  1. During Validate/Push a terminating error behavior has been introduced if there is no valid deploymentList produced when expected.

Testing Evidence

Tested deployment of malformed .json template and message level change output.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers temporarily deployed to test February 28, 2022 14:11 Inactive
@Jefajers Jefajers marked this pull request as ready for review February 28, 2022 14:51
@Jefajers Jefajers requested a review from a team as a code owner February 28, 2022 14:51
Copy link
Copy Markdown
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Json Scope Warnings should be treated as errors

2 participants