Skip to content

NIST SP workbook validation changes#12784

Merged
v-atulyadav merged 6 commits into
masterfrom
NIST-SP-workbook
Sep 24, 2025
Merged

NIST SP workbook validation changes#12784
v-atulyadav merged 6 commits into
masterfrom
NIST-SP-workbook

Conversation

@Alekhya0824
Copy link
Copy Markdown
Contributor

Required items, please complete

Change(s):
Updated the hyperlinks which are not working

Reason for Change(s):
few of the hyperlinks are not working

Version Updated:

yes
Testing Completed:

yes
Checked that the validations are passing and have addressed any issues that are present:

yes

@Alekhya0824 Alekhya0824 requested review from a team as code owners September 11, 2025 10:18
@v-maheshbh v-maheshbh self-assigned this Sep 11, 2025
@v-maheshbh v-maheshbh added the Workbook Workbook specialty review needed label Sep 11, 2025
@v-shukore v-shukore assigned v-shukore and unassigned v-maheshbh Sep 12, 2025
@Alekhya0824 Alekhya0824 requested a review from a team as a code owner September 23, 2025 08:17
@rahul0216 rahul0216 requested a review from Copilot September 23, 2025 10:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates hyperlinks and fixes broken metrics in the NIST SP 800-53 R4 workbook validation, incrementing the solution version from 3.0.1 to 3.0.2.

  • Updated several broken or outdated hyperlinks throughout the workbook
  • Fixed broken metrics and queries, including correcting table names and URLs
  • Version bumps across multiple configuration files to reflect these changes

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Workbooks/WorkbooksMetadata.json Version bump from 1.0.0 to 1.1.0 for workbook metadata
Solutions/NISTSP80053/data/Solution_NISTSP80053.json Solution version increment from 3.0.1 to 3.0.2
Solutions/NISTSP80053/Workbooks/NISTSP80053.json Multiple hyperlink updates, query fixes, and metric corrections
Solutions/NISTSP80053/ReleaseNotes.md Added release notes entry for version 3.0.2
Solutions/NISTSP80053/Package/createUiDefinition.json Minor formatting improvement in description
Comments suppressed due to low confidence (1)

Solutions/NISTSP80053/Workbooks/NISTSP80053.json:1

{

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Solutions/NISTSP80053/Workbooks/NISTSP80053.json
@rahul0216
Copy link
Copy Markdown
Collaborator

image I think one bracket is missing here.

@v-atulyadav v-atulyadav merged commit dfc9fe1 into master Sep 24, 2025
32 checks passed
@github-actions github-actions Bot deleted the NIST-SP-workbook branch May 28, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content-Package Workbook Workbook specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants