NIST SP workbook validation changes#12784
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates hyperlinks and fixes broken metrics in the NIST SP 800-53 R4 workbook validation, incrementing the solution version from 3.0.1 to 3.0.2.
- Updated several broken or outdated hyperlinks throughout the workbook
- Fixed broken metrics and queries, including correcting table names and URLs
- Version bumps across multiple configuration files to reflect these changes
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Workbooks/WorkbooksMetadata.json | Version bump from 1.0.0 to 1.1.0 for workbook metadata |
| Solutions/NISTSP80053/data/Solution_NISTSP80053.json | Solution version increment from 3.0.1 to 3.0.2 |
| Solutions/NISTSP80053/Workbooks/NISTSP80053.json | Multiple hyperlink updates, query fixes, and metric corrections |
| Solutions/NISTSP80053/ReleaseNotes.md | Added release notes entry for version 3.0.2 |
| Solutions/NISTSP80053/Package/createUiDefinition.json | Minor formatting improvement in description |
Comments suppressed due to low confidence (1)
Solutions/NISTSP80053/Workbooks/NISTSP80053.json:1
- The URL update from 'https://portal.atp.azure.com/' to 'https://security.microsoft.com/settings/identities' for Microsoft Defender for Identity is correct as the old portal has been migrated to the unified Microsoft 365 Defender portal.
{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
rahul0216
approved these changes
Sep 24, 2025
v-shukore
approved these changes
Sep 24, 2025
v-atulyadav
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Required items, please complete
Change(s):
Updated the hyperlinks which are not working
Reason for Change(s):
few of the hyperlinks are not working
Version Updated:
yes
Testing Completed:
yes
Checked that the validations are passing and have addressed any issues that are present:
yes