Skip to content

RecordedFuture: Add IOC-Enrichment threshold#13545

Merged
v-atulyadav merged 13 commits into
Azure:masterfrom
recordedfuture:ioc-enrichment-threshold
Apr 2, 2026
Merged

RecordedFuture: Add IOC-Enrichment threshold#13545
v-atulyadav merged 13 commits into
Azure:masterfrom
recordedfuture:ioc-enrichment-threshold

Conversation

@aommm
Copy link
Copy Markdown
Contributor

@aommm aommm commented Feb 3, 2026

Change(s):
- Add RiskScoreThreshold to RecordedFuture-IOC_Enrichment logic app. If risk score is lower than threshold, won't post comment to incident

Version Updated:

  • Yes

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

@aommm aommm requested review from a team as code owners February 3, 2026 12:09
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Feb 3, 2026
@v-shukore
Copy link
Copy Markdown
Contributor

Hi @aommm, please fix arm-ttk validation failures. Thanks!!

@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Feb 4, 2026

Hi @v-shukore ,
I looked at the logs now and I would appreciate some assistance.

  • General question: can I run the validation locally?

apiVersions Should Be Recent

  • How can we see which resources the failures are referring to? I don't see it in the github action logs, it doesn't refer to in which files/lines the failure occurred.
  • How to figure out a correct API version for e.g. Microsoft.OperationalInsights/workspaces/providers/contentTemplates?
    • When I now bump the API version for these resources, could this result in breaking changes?

URIs Should Be Properly Constructed

  • Similar question here, how can I see where the failures occurred, which URIs is it referring to?

Thanks!

@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Feb 10, 2026

Hi @v-shukore , could you offer any guidance on this? 🙏

@v-shukore
Copy link
Copy Markdown
Contributor

v-shukore commented Feb 11, 2026

Hi @aommm, you can validate this locally. If the arm-ttk check is failing, please review the maintemplate.json file and update it accordingly. Thanks!
image

@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Feb 11, 2026

@v-shukore please see my questions above

@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Feb 17, 2026

@v-shukore we haven't changed anything relating to URLs or apiVersions so it's hard for us to know what to do about the failure. Could you offer any guidance on the questions above? We have customers waiting for this fix so would be nice to get this merged ASAP.

@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Feb 23, 2026

@v-atulyadav , could you give us any guidance here on how to proceed? It seems @v-shukore is not active anymore.

@v-shukore
Copy link
Copy Markdown
Contributor

Hi @aommm, sorry for the delay. I am currently looking into this issue and will need some time. Thanks.

@v-shukore
Copy link
Copy Markdown
Contributor

Hi @aommm, could you please update this branch with master once. Thanks!!

@aommm aommm force-pushed the ioc-enrichment-threshold branch from fbd5d56 to 279fee4 Compare February 23, 2026 12:35
@aommm aommm force-pushed the ioc-enrichment-threshold branch from 279fee4 to a1a063c Compare February 23, 2026 12:37
@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Feb 23, 2026

Thanks for the prompt reply @v-shukore , much appreciated :) I rebased the branch now

@v-shukore
Copy link
Copy Markdown
Contributor

Hi @aommm, ARM‑TTK is still failing for the same issue. I’m reviewing this internally and will update you shortly. Thanks!

@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Mar 2, 2026

Hi @v-shukore , any update on this? 🙏

@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Mar 9, 2026

@v-shukore did you figure out what the errors mean or which part of mainTemplate.json is problematic?

@v-shukore
Copy link
Copy Markdown
Contributor

Hi @aommm, could you please grant me the access of this branch I need to do some troubleshooting to find the cause of arm-ttk failure. Thanks!!

@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Mar 10, 2026

@v-shukore I don't have acess to these repository settings unfortunately. Alternatively, could you check out this branch and then create a new branch from it, that you push to the Azure/Azure-Sentinel remote?

@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Mar 16, 2026

@v-shukore / @v-atulyadav we would be grateful if you could expedite this. We have been waiting since 3rd of February (almost 6 weeks) and we still have no info on how to proceed. If you cannot do anything without push access then please say so, and I can contact various IT departments to see if I can get you access.

Also as previously mentioned, it's not possible for us to work on this ourselves since

  1. the pipeline logs don't mention where the problem occurs.
  2. we don't know how to run the validation locally.

In addition to helping us with this PR, it would be great if you could eventually address these two items. That would be helpful for the future and for other contributors. Thanks!

@v-shukore
Copy link
Copy Markdown
Contributor

Hi @aommm, we checked and found that the issue continues because of a recent change in the Playbook. To fix it, please remove the URL from the Maybe_add_comment_to_incident_(V3)_-_URL parameter in the playbook and replace it with another word, as shown in the screenshot. Thanks!!
image

@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Mar 23, 2026

Hi @v-shukore , thanks for investigating! Looks like it was tricky to find the cause, but glad that you found it.

I pushed a fix now where I changed it from "URL" to "Url" - let's see if that works. Can you re-run the validation pipeline? (There was another step called Parse_JSON_-_Url which made me think that it may be OK to just change the casing)

@v-shukore v-shukore requested a review from Copilot March 24, 2026 03:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a configurable risk-score threshold to the Recorded Future IOC enrichment playbook to reduce incident comment noise by skipping comments for low-risk entities.

Changes:

  • Added RiskScoreThreshold parameter and gating If conditions before adding incident comments in the logic app.
  • Updated playbook documentation and solution release notes to describe the new threshold behavior.
  • Bumped solution version metadata.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 8 comments.

File Description
Solutions/Recorded Future/ReleaseNotes.md Adds release note entry for the new threshold behavior/version.
Solutions/Recorded Future/Playbooks/Enrichment/readme.md Documents the threshold-based comment suppression behavior.
Solutions/Recorded Future/Playbooks/Enrichment/RecordedFuture-IOC_Enrichment/azuredeploy.json Implements RiskScoreThreshold and conditionally posts comments based on risk score.
Solutions/Recorded Future/Data/Solution_RecordedFuture.json Updates solution version and base path metadata.

Comment thread Solutions/Recorded Future/Data/Solution_RecordedFuture.json
Comment thread Solutions/Recorded Future/ReleaseNotes.md Outdated
Comment thread Solutions/Recorded Future/Playbooks/Enrichment/readme.md
Comment thread Solutions/Recorded Future/Playbooks/Enrichment/readme.md
@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Mar 30, 2026

Hi @v-shukore , please have a look at the updated Release notes.

@v-shukore
Copy link
Copy Markdown
Contributor

Hi @aommm, I ran arm-ttk locally, but it's still failing. I believe there might be another URL in the code, as shown in the screenshot below. Please update that as well and commit. Thanks!
image

@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Apr 1, 2026

Fixed and pushed, @v-shukore , please have a look!

@v-shukore
Copy link
Copy Markdown
Contributor

Hi @aommm, I checked and the issue is still persisting. I tested locally by removing the entire URL word, and after that, arm-ttk did not fail. Please remove it and commit the changes as shown in the screenshot below. Thanks!
image

@aommm
Copy link
Copy Markdown
Contributor Author

aommm commented Apr 1, 2026

@v-shukore thanks for checking. I renamed it to something totally different now, please try again!

@v-atulyadav v-atulyadav merged commit f72d2ca into Azure:master Apr 2, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants