Skip to content

AWS EKS revert cloudformation template#13812

Merged
jlheard merged 3 commits into
Azure:masterfrom
fuqing04:user/fuqingwang/AWSEKS
Mar 12, 2026
Merged

AWS EKS revert cloudformation template#13812
jlheard merged 3 commits into
Azure:masterfrom
fuqing04:user/fuqingwang/AWSEKS

Conversation

@fuqing04
Copy link
Copy Markdown
Contributor

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@fuqing04 fuqing04 requested review from a team as code owners March 12, 2026 20:32
@jlheard jlheard merged commit 21e561e into Azure:master Mar 12, 2026
33 checks passed
@v-atulyadav
Copy link
Copy Markdown
Collaborator

Hi @fuqing04, @jlheard,

We need all previous versions of the zip files, but it seems that the 3.0.0 zip has been removed, which is not acceptable as per the standard. Thanks

image

@v-atulyadav v-atulyadav self-assigned this Mar 13, 2026
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Mar 13, 2026
@fuqing04
Copy link
Copy Markdown
Contributor Author

fuqing04 commented Mar 13, 2026

Hi @fuqing04, @jlheard,

We need all previous versions of the zip files, but it seems that the 3.0.0 zip has been removed, which is not acceptable as per the standard. Thanks

image

I didn't notice the zip was removed. I suspect some of the ref got tainted. I created a new PR, can you take a look? #13826

@fuqing04 fuqing04 deleted the user/fuqingwang/AWSEKS branch April 13, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants