Fix an issue with CORS when a preflight request has an empty headers list#30
Merged
edwin-huber merged 1 commit intoAzure:devfrom Jul 14, 2018
Merged
Conversation
…list. Without this fix, azurite would fail because it was trying to call request.httpProps[N.ACCESS_CONTROL_REQUEST_HEADERS].toLowerCase() which will result in trying to call undefined.toLowerCase() if the preflight request doesn't specify access-control-request-headers. In addition, when validating a request against the CORS, the request would fail to be validated if access-control-request-headers was empty.
|
|
Collaborator
|
Many thanks for your contribution! |
gpatryk
pushed a commit
to gpatryk/Azurite
that referenced
this pull request
Dec 7, 2018
Fix an issue with CORS when a preflight request has an empty headers list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, azurite would fail because it was trying to call
request.httpProps[N.ACCESS_CONTROL_REQUEST_HEADERS].toLowerCase()which will result in trying to call undefined.toLowerCase() if the preflight
request doesn't specify access-control-request-headers.
In addition, when validating a request against the CORS, the request would
fail to be validated if access-control-request-headers was empty.