bl-select always defaults to focusFirstOption()

[ascobie]

Select defined as:

<bl-select placeholder="Filter" [ngModel]="pickedFilter" (ngModelChange)="pickSelectedFilter($event)">
    <bl-option *ngFor="let filter of optionFilters;trackBy:trackFilterOption"
        [label]="filter.label"
        [value]="filter.value">
    </bl-option>
</bl-select>

ngModel has the correct default value, but the fist option is always picked, even though when i open the picker, the correct item based on the model is selected.

But opening the option list has the first item selected:

When it should be the one that matches the model.

[ascobie]

Update, setting the focused value in here fixes it, but not sure if this would have any flow on effects:

    public writeValue(value: any): void {
        if (this.multiple) {
            this.selected = new Set(value);
        } else {
            this.selected = new Set(value ? [value] : []);
            this.focusedOption = value; <<=============
        }
        this.changeDetector.markForCheck();
    }

[timotheeguerin]

i have a branch with v2 of the select. Current version has a few issues when there is not enough space to display or the parent is overflow hidden.

I'll update there.

[ascobie]

Cool, thanks. I'll revert the change I made. Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Timothee Guerin <notifications@github.com> Sent: Wednesday, April 11, 2018 3:35:28 PM To: Azure/BatchLabs Cc: Andrew Scobie; Author Subject: Re: [Azure/BatchLabs] bl-select always defaults to focusFirstOption() (#1258) i have a branch with v2 of the select. Current version has a few issues when there is not enough space to display or the parent is overflow hidden. I'll update there. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FBatchLabs%2Fissues%2F1258%23issuecomment-380316437&data=02%7C01%7Candrew.scobie%40microsoft.com%7Ceeec06521031457548a708d59f5d4553%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636590145300688813&sdata=Ge%2Bb6Jfr9n3kNjQrb5lR1%2FuIj6OohmJNLdoWyfr8GhU%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKbYVkMdv-NkAgKAS3nMb_1vVOGF5zsEks5tnXoAgaJpZM4TPRMg&data=02%7C01%7Candrew.scobie%40microsoft.com%7Ceeec06521031457548a708d59f5d4553%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636590145300698822&sdata=%2Fqs19gzy8tZc1sHGX03DWRMgPK9l4lbNTyXE3lF2gBI%3D&reserved=0>.