Handle extenal parameters for NCJ#1049
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
=========================================
Coverage ? 53.48%
=========================================
Files ? 866
Lines ? 20249
Branches ? 2274
=========================================
Hits ? 10830
Misses ? 9419
Partials ? 0
Continue to review full report at Codecov.
|
| variables: NcjJobConfiguration; | ||
| variables?: StringMap<any>; | ||
| pool: StringMap<string>; | ||
| } |
There was a problem hiding this comment.
@timotheeguerin, can you double check this change. it seemed wrong and like a copy/paste issue. didn't matter with binding raw JSON to it, but the tests picked it up.
| @@ -0,0 +1,215 @@ | |||
| import { Component, DebugElement, NO_ERRORS_SCHEMA } from "@angular/core"; | |||
There was a problem hiding this comment.
I started moving the test out of the test dir and putting them next to the file they are testing. I feel this makes test writing much easier and force us to have a better structure otherwise folder are overloaded with different files.
For a component I do a folder in this format:
component-name
component-name.component.ts
component-name.component.spec.ts
component-name.html
component-name.scss
index.ts
I think we should change the test out of the test dir when we add a new one or update an existing one
Fix: #953