Skip to content

Handle extenal parameters for NCJ#1049

Merged
ascobie merged 18 commits into
masterfrom
feature/handle-external-ncj-parameters
Feb 26, 2018
Merged

Handle extenal parameters for NCJ#1049
ascobie merged 18 commits into
masterfrom
feature/handle-external-ncj-parameters

Conversation

@ascobie
Copy link
Copy Markdown
Member

@ascobie ascobie commented Feb 2, 2018

Fix: #953

  • Pass in parameters from an external app
  • Update route query parameters on change
  • Add validation for file in file group
  • Handle the file group prefix so that it doesn't break on reload
  • Tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0a612ba). Click here to learn what that means.
The diff coverage is 85.96%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1049   +/-   ##
=========================================
  Coverage          ?   53.48%           
=========================================
  Files             ?      866           
  Lines             ?    20249           
  Branches          ?     2274           
=========================================
  Hits              ?    10830           
  Misses            ?     9419           
  Partials          ?        0
Impacted Files Coverage Δ
...-file-picker/cloud-file-picker-dialog.component.ts 28.12% <ø> (ø)
app/models/ncj-job-template.ts 100% <ø> (ø)
src/common/constants/constants.ts 100% <100%> (ø)
...d/cloud-file-picker/cloud-file-picker.component.ts 71.15% <69.23%> (ø)
...nts/market/submit/submit-ncj-template.component.ts 71.34% <90.69%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a612ba...7bcd6a3. Read the comment docs.

variables: NcjJobConfiguration;
variables?: StringMap<any>;
pool: StringMap<string>;
}
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timotheeguerin, can you double check this change. it seemed wrong and like a copy/paste issue. didn't matter with binding raw JSON to it, but the tests picked it up.

@@ -0,0 +1,215 @@
import { Component, DebugElement, NO_ERRORS_SCHEMA } from "@angular/core";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started moving the test out of the test dir and putting them next to the file they are testing. I feel this makes test writing much easier and force us to have a better structure otherwise folder are overloaded with different files.

For a component I do a folder in this format:

component-name
component-name.component.ts
component-name.component.spec.ts
component-name.html
component-name.scss
index.ts

I think we should change the test out of the test dir when we add a new one or update an existing one

@ascobie ascobie merged commit 4f0b99a into master Feb 26, 2018
@ascobie ascobie deleted the feature/handle-external-ncj-parameters branch February 26, 2018 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Blender plugin to test BL Custom Protocol

2 participants