Skip to content

Internal: Replace electron require by service injection#1141

Merged
timotheeguerin merged 14 commits into
masterfrom
internal/no-electron-require
Mar 12, 2018
Merged

Internal: Replace electron require by service injection#1141
timotheeguerin merged 14 commits into
masterfrom
internal/no-electron-require

Conversation

@timotheeguerin
Copy link
Copy Markdown
Member

fix #1140

Also removed the electron preprocessor that is causing issues in the test randomly

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2018

Codecov Report

Merging #1141 into master will decrease coverage by 0.02%.
The diff coverage is 44.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
- Coverage    53.4%   53.38%   -0.03%     
==========================================
  Files         919      924       +5     
  Lines       20959    21024      +65     
  Branches     2344     2346       +2     
==========================================
+ Hits        11194    11223      +29     
- Misses       9765     9801      +36
Impacted Files Coverage Δ
src/common/constants/constants.ts 100% <ø> (ø) ⬆️
app/services/index.ts 100% <ø> (ø) ⬆️
src/@batch-flask/ui/electron/shell.service.ts 16.66% <0%> (ø)
...pp/components/pool/graphs/pool-graphs.component.ts 27.11% <0%> (ø) ⬆️
app/utils/constants.ts 100% <100%> (ø) ⬆️
src/@batch-flask/ui/batchui.module.ts 100% <100%> (ø) ⬆️
...ponents/application/details/configuration/index.ts 100% <100%> (ø)
src/@batch-flask/ui/index.ts 100% <100%> (ø) ⬆️
...ents/common/inline-quota/inline-quota.component.ts 19.04% <100%> (+1.3%) ⬆️
...raphs/job-graphs-home/job-graphs-home.component.ts 18% <100%> (+0.82%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f968d...fd691cf. Read the comment docs.

@timotheeguerin timotheeguerin merged commit f7df1dd into master Mar 12, 2018
@timotheeguerin timotheeguerin deleted the internal/no-electron-require branch March 12, 2018 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all import from "electron"

1 participant