Feature: certificate implementation#1176
Conversation
-Fixed a small error previously made in job schedule proxy
added certificate components in app module and routes
Some html/component updates
added node-forge
| canActivate: [NavigationGuard], | ||
| component: CertificateHomeComponent, | ||
| children: [ | ||
| { path: "", component: CertificateDefaultComponent }, // thumbprint/ |
There was a problem hiding this comment.
comment should be certificates/ no?
| "mousetrap": "^1.6.0", | ||
| "ms-rest-js": "~0.2.3", | ||
| "node-fetch": "~1.7.3", | ||
| "node-forge": "^0.7.4", |
There was a problem hiding this comment.
I just registered for OSS approval
| import { List } from "immutable"; | ||
| import { AsyncSubject, Observable, Subject } from "rxjs"; | ||
| // tslint:disable-next-line:no-var-requires | ||
| const forge = require("node-forge"); |
| * @param file | ||
| */ | ||
| public getCertificateExtension(file: File) { | ||
| return file.name.substr(file.name.length - 3, 3).toLowerCase(); |
There was a problem hiding this comment.
Use FileUrlUtils#getFileExtension()
| return this._basicProperties; | ||
| } | ||
|
|
||
| public list(options?: any, forceNew?: boolean); |
There was a problem hiding this comment.
is there actually a listNext for certificates?
There was a problem hiding this comment.
Yes, there is nextLink in certificateListResult
| @@ -0,0 +1,3 @@ | |||
| <bl-simple-form [submit]="ok" [containerRef]="dialogRef" [multiUse]="false" size="small" actionName="Enable" title="Reactivate certificate"> | |||
| <p>Do you want to reactivate the certificate'<b>{{certificateThumbprint}}</b>'?</p> | |||
There was a problem hiding this comment.
need space or ': ' between here:
certificate'{{certificateThumbprint}}'
| import { ContextMenu, ContextMenuItem } from "@batch-flask/ui/context-menu"; | ||
| import { LoadingStatus } from "@batch-flask/ui/loading"; | ||
| import { QuickListItemStatus } from "@batch-flask/ui/quick-list"; | ||
| import { Certificate, CertificateState } from "app/models"; |
There was a problem hiding this comment.
I have been adding a line break between @batch-flask imports and the other app imports. I think it makes it cleaner and easier to read.
There was a problem hiding this comment.
@batch-flask imports can be added to the external imports above, as its techincally supposed to act like an external library
| case CertificateState.active: | ||
| return ""; | ||
| default: | ||
| return `Certficate is ${certificate.state}`; |
| import { ActivatedRoute, Router } from "@angular/router"; | ||
| import { autobind } from "@batch-flask/core"; | ||
| import { ElectronRemote } from "@batch-flask/ui"; | ||
| import { Observable, Subscription } from "rxjs"; |
There was a problem hiding this comment.
move flask imports out of this block
There was a problem hiding this comment.
i think they belong here
There was a problem hiding this comment.
ok cool. if you are happy then i am also :)
Codecov Report
@@ Coverage Diff @@
## master #1176 +/- ##
==========================================
- Coverage 53.66% 53.38% -0.29%
==========================================
Files 941 946 +5
Lines 21343 21538 +195
Branches 2364 2394 +30
==========================================
+ Hits 11454 11497 +43
- Misses 9889 10041 +152
Continue to review full report at Codecov.
|
-Fixed typo, spell, and misc issues.
3 participants
Fix #1165. npmImplement certificate interface for BatchLab including: