Skip to content

Add node deallocation option to pool scale form#1230

Merged
ascobie merged 8 commits intomasterfrom
feature/deallocation-option
Apr 6, 2018
Merged

Add node deallocation option to pool scale form#1230
ascobie merged 8 commits intomasterfrom
feature/deallocation-option

Conversation

@ascobie
Copy link
Copy Markdown
Member

@ascobie ascobie commented Apr 5, 2018

Fix: #1212

capture

Note, have fixed the typo in the above image.
New properties are being sent to the service:

capture

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2018

Codecov Report

Merging #1230 into master will increase coverage by 0.1%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1230     +/-   ##
========================================
+ Coverage    53.3%   53.4%   +0.1%     
========================================
  Files         953     954      +1     
  Lines       21859   21912     +53     
  Branches     2443    2453     +10     
========================================
+ Hits        11651   11702     +51     
- Misses      10208   10210      +2
Impacted Files Coverage Δ
src/@batch-flask/core/material.module.ts 100% <ø> (ø) ⬆️
app/services/batch-api/poolProxy.ts 8.69% <0%> (+1%) ⬆️
app/models/dtos/pool-resize.dto.ts 100% <100%> (ø) ⬆️
...ails/error-display/pool-error-display.component.ts 60% <100%> (ø) ⬆️
app/components/pool/action/scale/index.ts 100% <100%> (ø) ⬆️
...pool/action/resize/pool-resize-dialog.component.ts 28.88% <33.33%> (-0.66%) ⬇️
...tion/scale/deallocation-option-picker.component.ts 91.3% <91.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384ff58...a722885. Read the comment docs.

@ascobie ascobie merged commit cd980ed into master Apr 6, 2018
@ascobie ascobie deleted the feature/deallocation-option branch April 6, 2018 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resize Pool options for node termination (like Portal)

1 participant