Skip to content

Feature: Better style for sidebar bookmarks and middle click to close#1254

Merged
timotheeguerin merged 11 commits into
masterfrom
feature/improve-bookmark
Apr 10, 2018
Merged

Feature: Better style for sidebar bookmarks and middle click to close#1254
timotheeguerin merged 11 commits into
masterfrom
feature/improve-bookmark

Conversation

@timotheeguerin
Copy link
Copy Markdown
Member

@timotheeguerin timotheeguerin commented Apr 10, 2018

fix #1253
fix #1217 (Close middle click)

image

Virtual folder show slightly transparent to let user know its now actually present until uploading files
image

@timotheeguerin timotheeguerin changed the title Better style for sidebar bookmarks Feature: Better style for sidebar bookmarks and middle click to close Apr 10, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2018

Codecov Report

Merging #1254 into master will decrease coverage by 0.01%.
The diff coverage is 38.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
- Coverage   53.37%   53.35%   -0.02%     
==========================================
  Files         958      959       +1     
  Lines       22165    22177      +12     
  Branches     2479     2481       +2     
==========================================
+ Hits        11830    11833       +3     
- Misses      10335    10344       +9
Impacted Files Coverage Δ
src/@batch-flask/ui/sidebar/index.ts 100% <100%> (ø) ⬆️
src/@batch-flask/ui/sidebar/sidebar.module.ts 100% <100%> (ø)
...@batch-flask/ui/sidebar/sidebar-bookmarks/index.ts 100% <100%> (ø)
...r/sidebar-bookmarks/sidebar-bookmarks.component.ts 19.23% <19.23%> (ø)
...count/action/add/batch-account-create.component.ts 74.13% <80%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13bfba9...54b04a8. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 9716a34 into master Apr 10, 2018
@timotheeguerin timotheeguerin deleted the feature/improve-bookmark branch April 10, 2018 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the sidebar bookmark dropdown Opened form dropdown. close with middle click

1 participant