Skip to content

Fix: Broken folder delete and redesign logic#1291

Merged
timotheeguerin merged 4 commits into
masterfrom
fix/delete-blob
Apr 19, 2018
Merged

Fix: Broken folder delete and redesign logic#1291
timotheeguerin merged 4 commits into
masterfrom
fix/delete-blob

Conversation

@timotheeguerin
Copy link
Copy Markdown
Member

fix #1290

This also redesign how delete files works by having a field on a file navigator to specify how to delete files

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2018

Codecov Report

Merging #1291 into master will decrease coverage by 0.02%.
The diff coverage is 20.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
- Coverage   53.44%   53.41%   -0.03%     
==========================================
  Files         976      976              
  Lines       22753    22769      +16     
  Branches     2558     2562       +4     
==========================================
+ Hits        12160    12162       +2     
- Misses      10593    10607      +14
Impacted Files Coverage Δ
src/@batch-flask/ui/dialogs/dialog.service.ts 21.73% <ø> (ø) ⬆️
...blob-files-browser/blob-files-browser.component.ts 33.33% <ø> (+7.01%) ⬆️
...-flask/ui/dialogs/confirmation-dialog.component.ts 53.84% <ø> (ø) ⬆️
...xplorer/file-tree-view/file-tree-view.component.ts 9.67% <0%> (-0.42%) ⬇️
...le/browse/file-explorer/file-explorer.component.ts 22.22% <10.71%> (-6.14%) ⬇️
src/@batch-flask/ui/index.ts 100% <100%> (ø) ⬆️
...flask/ui/form/simple-form/simple-form.component.ts 100% <100%> (ø) ⬆️
app/services/file/file-navigator/file-navigator.ts 43.62% <11.53%> (-7.19%) ⬇️
app/services/storage/storage-blob.service.ts 11.96% <50%> (+0.77%) ⬆️
...ask/ui/form/complex-form/complex-form.component.ts 65.64% <80%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196984a...8a0fc5c. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 81052a8 into master Apr 19, 2018
@timotheeguerin timotheeguerin deleted the fix/delete-blob branch April 19, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleting folder is broken with new storageAccountId

1 participant