Skip to content

Fix: Prod build broken due to AOT dynamic injection not working#1313

Merged
timotheeguerin merged 2 commits into
masterfrom
fix/aot-dep-injection
Apr 27, 2018
Merged

Fix: Prod build broken due to AOT dynamic injection not working#1313
timotheeguerin merged 2 commits into
masterfrom
fix/aot-dep-injection

Conversation

@timotheeguerin
Copy link
Copy Markdown
Member

fix #1311

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2018

Codecov Report

Merging #1313 into master will decrease coverage by 0.04%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
- Coverage   52.98%   52.94%   -0.05%     
==========================================
  Files         993      990       -3     
  Lines       23212    23193      -19     
  Branches     2622     2622              
==========================================
- Hits        12300    12280      -20     
- Misses      10912    10913       +1
Impacted Files Coverage Δ
src/@batch-flask/ui/index.ts 100% <ø> (ø) ⬆️
src/@batch-flask/ui/batchui.module.ts 100% <ø> (ø) ⬆️
...task/browse/display/task-list-display.component.ts 45.16% <0%> (-0.3%) ⬇️
...mponents/job/action/disable/disable-job.command.ts 41.17% <0%> (-8.83%) ⬇️
...ents/job/action/terminate/terminate-job.command.ts 50% <0%> (-5.56%) ⬇️
...@batch-flask/ui/entity-commands/entity-commands.ts 31.48% <0%> (-2.45%) ⬇️
...ount/browse/account-list/account-list.component.ts 71.83% <100%> (-0.78%) ⬇️
...s/application/browse/application-list.component.ts 78.18% <100%> (ø) ⬆️
...pp/components/job/details/job-details.component.ts 32.91% <50%> (+0.41%) ⬆️
.../components/pool/details/pool-details.component.ts 27.16% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f0fa3d...23be5f6. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 1043a3c into master Apr 27, 2018
@timotheeguerin timotheeguerin deleted the fix/aot-dep-injection branch April 27, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prod build is borken with the new Commands

1 participant