Skip to content

Feature: metadata picker#1321

Merged
johnnyzhang82 merged 6 commits into
masterfrom
feature/metaDataKeyValue
May 7, 2018
Merged

Feature: metadata picker#1321
johnnyzhang82 merged 6 commits into
masterfrom
feature/metaDataKeyValue

Conversation

@johnnyzhang82
Copy link
Copy Markdown
Contributor

@johnnyzhang82 johnnyzhang82 commented May 1, 2018

Fixed #1318, Added metadata picker in

  1. pool create form
  2. job create/edit form
  3. job schedule create/edit form
  • Fixed datetime picker calender icon size issue
  • Fixed json editor caches previous data when first time load after close unsaved form
  • Fixed editable table not populating default for empty table when switching view issue

image

-Fixed a bug that reopen json editor will show last unsaved form data
-Fixed a bug that switching to json editor will erase default entry of editable grid
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2018

Codecov Report

Merging #1321 into master will increase coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1321      +/-   ##
==========================================
+ Coverage   52.95%   52.95%   +<.01%     
==========================================
  Files         990      990              
  Lines       23204    23205       +1     
  Branches     2627     2627              
==========================================
+ Hits        12288    12289       +1     
  Misses      10916    10916
Impacted Files Coverage Δ
.../add/job-schedule-create-basic-dialog.component.ts 31.7% <ø> (ø) ⬆️
...ob/action/add/job-create-basic-dialog.component.ts 68.23% <ø> (ø) ⬆️
...l/action/add/pool-create-basic-dialog.component.ts 12.38% <ø> (ø) ⬆️
src/@batch-flask/ui/editor/editor.component.ts 22.36% <0%> (-0.3%) ⬇️
app/models/forms/create-job-model.ts 100% <100%> (ø) ⬆️
...ui/form/editable-table/editable-table.component.ts 100% <100%> (+1.58%) ⬆️
app/models/forms/create-pool-model.ts 17.5% <100%> (ø) ⬆️
app/models/forms/create-job-schedule-model.ts 21.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba11833...45e1bf2. Read the comment docs.

@johnnyzhang82 johnnyzhang82 merged commit 933beda into master May 7, 2018
@johnnyzhang82 johnnyzhang82 deleted the feature/metaDataKeyValue branch May 7, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add and update metadata for entities

2 participants