Skip to content

Feature: Validate paths in file group folder/file picker#1376

Merged
timotheeguerin merged 7 commits into
masterfrom
feature/validate-paths
May 25, 2018
Merged

Feature: Validate paths in file group folder/file picker#1376
timotheeguerin merged 7 commits into
masterfrom
feature/validate-paths

Conversation

@timotheeguerin
Copy link
Copy Markdown
Member

fix #1362

image

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2018

Codecov Report

Merging #1376 into master will decrease coverage by 23.3%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1376       +/-   ##
===========================================
- Coverage   53.59%   30.29%   -23.31%     
===========================================
  Files        1003     1004        +1     
  Lines       23691    23714       +23     
  Branches     2715     2717        +2     
===========================================
- Hits        12698     7184     -5514     
- Misses      10993    16530     +5537
Impacted Files Coverage Δ
app/components/data/action/add/index.ts 100% <ø> (ø) ⬆️
...ents/data/shared/file-or-directory-picker/index.ts 100% <100%> (ø)
app/components/data/shared/data.shared.module.ts 100% <100%> (ø) ⬆️
...ctory-picker/file-or-directory-picker.component.ts 70% <92.85%> (ø)
...pp/services/app-insights/query-result-processor.ts 3.33% <0%> (-96.67%) ⬇️
...tch-flask/core/key-navigator/list-key-navigator.ts 4.04% <0%> (-94.95%) ⬇️
app/utils/cloud-path-utils/cloud-path-utils.ts 8.33% <0%> (-91.67%) ⬇️
app/services/core/poll-service.ts 5.81% <0%> (-90.7%) ⬇️
...pp/components/pool/graphs/heatmap/heatmap-color.ts 4.76% <0%> (-90.48%) ⬇️
src/common/deferred/deferred.ts 10% <0%> (-90%) ⬇️
... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0929e56...2d715fd. Read the comment docs.

@timotheeguerin timotheeguerin merged commit dfa5554 into master May 25, 2018
@timotheeguerin timotheeguerin deleted the feature/validate-paths branch May 25, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File group directory picker should validate directories exists

1 participant