Skip to content

Feature: Add key bindings configuration page#2007

Merged
timotheeguerin merged 6 commits into
masterfrom
feature/show-keyboard-shortcuts
Mar 29, 2019
Merged

Feature: Add key bindings configuration page#2007
timotheeguerin merged 6 commits into
masterfrom
feature/show-keyboard-shortcuts

Conversation

@timotheeguerin
Copy link
Copy Markdown
Member

@timotheeguerin timotheeguerin commented Mar 29, 2019

fix #2006
This is a ready only page for now. Key bindings cannot be edited

image

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 29, 2019

Codecov Report

Merging #2007 into master will increase coverage by 0.04%.
The diff coverage is 92.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2007      +/-   ##
==========================================
+ Coverage   65.37%   65.42%   +0.04%     
==========================================
  Files        1030     1032       +2     
  Lines       28234    28288      +54     
  Branches     5040     5045       +5     
==========================================
+ Hits        18459    18508      +49     
- Misses       9759     9764       +5     
  Partials       16       16
Impacted Files Coverage Δ
src/app/commands/list.appcmd.ts 9.52% <ø> (ø) ⬆️
src/app/commands/account.appcmd.ts 33.33% <ø> (ø) ⬆️
...core/commands/command-registry/command-registry.ts 100% <ø> (ø) ⬆️
src/app/commands/data.appcmd.ts 33.33% <ø> (ø) ⬆️
src/app/commands/pool.appcmd.ts 33.33% <ø> (ø) ⬆️
src/app/commands/job.appcmd.ts 33.33% <ø> (ø) ⬆️
...igation/profile-button/profile-button.component.ts 56.73% <0%> (-1.69%) ⬇️
.../@batch-flask/ui/keybindings/keybindings.module.ts 100% <100%> (ø)
...k/core/commands/keybindings/keybindings.service.ts 78.75% <100%> (+0.82%) ⬆️
...atch-flask/ui/keybindings/keybindings.component.ts 95.55% <95.55%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef16e48...9b3d91a. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 920ebf6 into master Mar 29, 2019
@timotheeguerin timotheeguerin deleted the feature/show-keyboard-shortcuts branch March 29, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page to see key bindings

1 participant