Skip to content

Feature: Add support for user key binding customization#2010

Merged
timotheeguerin merged 12 commits into
masterfrom
feature/user-keybindings
Apr 1, 2019
Merged

Feature: Add support for user key binding customization#2010
timotheeguerin merged 12 commits into
masterfrom
feature/user-keybindings

Conversation

@timotheeguerin
Copy link
Copy Markdown
Member

@timotheeguerin timotheeguerin commented Apr 1, 2019

fix #2009

image

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2019

Codecov Report

Merging #2010 into master will increase coverage by 0.04%.
The diff coverage is 74.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
+ Coverage   65.42%   65.47%   +0.04%     
==========================================
  Files        1032     1035       +3     
  Lines       28288    28453     +165     
  Branches     5045     5072      +27     
==========================================
+ Hits        18508    18630     +122     
- Misses       9764     9807      +43     
  Partials       16       16
Impacted Files Coverage Δ
.../@batch-flask/ui/keybindings/keybindings.module.ts 100% <100%> (ø) ⬆️
...nding-picker/keybinding-picker-dialog.component.ts 100% <100%> (ø)
src/@batch-flask/core/keys.ts 100% <100%> (ø) ⬆️
...e/commands/keybindings/user-keybindings.service.ts 25.64% <25.64%> (ø)
...k/core/commands/keybindings/keybindings.service.ts 78.07% <76.08%> (-0.68%) ⬇️
...atch-flask/ui/keybindings/keybindings.component.ts 91.25% <86.48%> (-4.31%) ⬇️
...k/ui/keybindings/keybindings-listener.directive.ts 95.83% <95.83%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 920ebf6...a9e2a36. Read the comment docs.

@timotheeguerin timotheeguerin merged commit e1ad4a3 into master Apr 1, 2019
@timotheeguerin timotheeguerin deleted the feature/user-keybindings branch April 1, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow key bindings to be edited by the user

1 participant