Skip to content

Fix starttask waitforsuccess#2093

Merged
cRui861 merged 5 commits into
masterfrom
fix-starttask-waitforsuccess
Oct 8, 2019
Merged

Fix starttask waitforsuccess#2093
cRui861 merged 5 commits into
masterfrom
fix-starttask-waitforsuccess

Conversation

@cRui861
Copy link
Copy Markdown
Member

@cRui861 cRui861 commented Sep 30, 2019

Sets waitForSuccess checkbox as checked as default. Tests for waitForSuccess.

Fix #2105

@cRui861 cRui861 self-assigned this Sep 30, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 30, 2019

Codecov Report

Merging #2093 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2093      +/-   ##
==========================================
+ Coverage   65.02%   65.09%   +0.07%     
==========================================
  Files         896      896              
  Lines       25629    25629              
  Branches     5054     5054              
==========================================
+ Hits        16664    16683      +19     
+ Misses       8965     8946      -19
Impacted Files Coverage Δ
...nts/pool/start-task/start-task-picker.component.ts 36% <ø> (+20%) ⬆️
...orm/key-value-picker/key-value-picker.component.ts 95.23% <0%> (+66.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d5442...3154a2b. Read the comment docs.

Comment thread src/app/components/pool/start-task/start-task-picker.component.spec.ts Outdated
@cRui861 cRui861 merged commit 3f72b6d into master Oct 8, 2019
@cRui861 cRui861 added this to the 2.4.0 milestone Oct 23, 2019
@cRui861 cRui861 added 🐛 bug and removed 🐛 bug labels Oct 24, 2019
@cRui861 cRui861 removed this from the 2.4.0 milestone Oct 24, 2019
@cRui861 cRui861 deleted the fix-starttask-waitforsuccess branch July 17, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StartTask WaitForSuccess should be defaulted to true

3 participants