Include the default Electron User-Agent string#2216
Merged
Conversation
dpwatrous
requested review from
bgklein,
cRui861,
gingi and
paterasMSFT
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2216 +/- ##
=======================================
Coverage 65.13% 65.14%
=======================================
Files 899 899
Lines 25654 25660 +6
Branches 5091 5092 +1
=======================================
+ Hits 16710 16715 +5
- Misses 8944 8945 +1
Continue to review full report at Codecov.
|
bgklein
approved these changes
Sep 10, 2020
Contributor
|
Also Fixes #2165 |
Member
Author
|
Good catch - I totally missed that this was basically the fix you had for Okta! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2212 and Fixes #2165
The User-Agent string being sent was exposing a bug in AAD auth when setting up 2-factor verification. Including the default Electron User-Agent string fixed this issue.