Conversation
dpwatrous
left a comment
There was a problem hiding this comment.
Good catch!
Not a blocker, but mind changing _saveFile() to take a string instead of any? If it had been typed we would have caught this on upgrading Electron.
|
Looks like there's also a unit testing issue (the call is probably just being mocked incorrectly now) |
be65b9f to
47d8a54
Compare
Fixed. Had to make several adjustments for promise-based testing. |
Codecov Report
@@ Coverage Diff @@
## master #2275 +/- ##
==========================================
- Coverage 65.23% 65.19% -0.04%
==========================================
Files 903 903
Lines 25693 25707 +14
Branches 5102 5102
==========================================
- Hits 16761 16760 -1
- Misses 8932 8947 +15
Continue to review full report at Codecov.
|
47d8a54 to
ad51945
Compare
Electron's `dialog.showSaveDialog` has changed at some point to return a `Promise` rather than a string value. Adjusted to the new API.
ad51945 to
81f600e
Compare
No description provided.