Skip to content

Comments

Added markdown linting#2292

Merged
dpwatrous merged 2 commits intomasterfrom
dpwatrous/markdownlint
Mar 9, 2021
Merged

Added markdown linting#2292
dpwatrous merged 2 commits intomasterfrom
dpwatrous/markdownlint

Conversation

@dpwatrous
Copy link
Member

Also fixed up all markdown files so there are no linting errors. Uses https://github.com/DavidAnson/markdownlint

gingi
gingi previously approved these changes Mar 6, 2021
Copy link
Member

@gingi gingi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

This was breaking due to other dependency changes, but shouldn't be needed
@dpwatrous
Copy link
Member Author

Looks like we had some ES6 polyfills for unit tests that relied on a transitive dependency. If the CI tests pass without them then I think we can safely say they're not needed.

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #2292 (597db9a) into master (f8b4ab8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2292   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files         903      903           
  Lines       25712    25712           
  Branches     5105     5105           
=======================================
  Hits        16763    16763           
  Misses       8949     8949           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad822e...0d1bcdc. Read the comment docs.

@dpwatrous dpwatrous requested a review from gingi March 7, 2021 14:57
@dpwatrous
Copy link
Member Author

dpwatrous commented Mar 7, 2021

One more thing to point out on this PR: I found some references to private NPM repos in package-lock.json and just regenerated it. I did it with NPM 7, so this does upgrade package-lock to v2.

We've already switched the package-lock files for the portal so IMO we might as well do it for Batch Explorer.

@dpwatrous dpwatrous merged commit 42894a5 into master Mar 9, 2021
@dpwatrous dpwatrous deleted the dpwatrous/markdownlint branch March 9, 2021 17:17
@cRui861 cRui861 linked an issue Apr 22, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add markdown linting

2 participants