Fix Screen Reader not announcing loading information when refreshing#2346
Merged
Fix Screen Reader not announcing loading information when refreshing#2346
Conversation
added 3 commits
June 30, 2021 13:55
* Update tests * Reverted dependency update
…n the screen is refreshed.
cRui861
requested review from
dpwatrous,
gingi,
paterasMSFT and
zfengms
as code owners
cRui861
changed the title
cRui861
changed the title
cRui861
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2346 +/- ##
=======================================
Coverage 65.23% 65.23%
=======================================
Files 903 903
Lines 26023 26024 +1
Branches 5115 5115
=======================================
+ Hits 16976 16977 +1
Misses 9047 9047
Continue to review full report at Codecov.
|
gingi
approved these changes
Jul 1, 2021
| @autobind() | ||
| public onClick() { | ||
| this.status = RefreshStatus.Refreshing; | ||
| this.liveAnnouncer.announce("Refreshing in progress"); |
Member
There was a problem hiding this comment.
Looks great, but can you make this a localized string? OK to also file a different issue to have that done at a later date.
Member
Author
|
Included in #2358 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen reader now announces loading information "Refresh in progress" while refreshing on Gallery page.