Feature: New file explorer#643
Merged
Merged
Conversation
…ure/better-file-explorer
ascobie
reviewed
Aug 30, 2017
|
|
||
| public treeRows: TreeRow[] = []; | ||
| public refreshing: boolean; | ||
| private _tree: FileTreeStructure; |
Member
There was a problem hiding this comment.
extreme nitpick, space between public and private. :)
ascobie
reviewed
Aug 30, 2017
|
|
||
| <bl-node-file-list #list [poolId]="task.poolId" [nodeId]="task.nodeId" [folder]="currentFolder" *ngIf="currentFolder"> | ||
| </bl-node-file-list> | ||
| Cur: {{currentFolder}} |
Member
There was a problem hiding this comment.
should this be "Current"? or is "Cur" ok here?
Member
Author
There was a problem hiding this comment.
nope should not be there, debugging, good catch
ascobie
reviewed
Aug 30, 2017
| public walk() { | ||
| return this.children.values(); | ||
| } | ||
| public markAsLoaded() { |
Member
There was a problem hiding this comment.
nitpick: newline between methods.
ascobie
reviewed
Aug 30, 2017
| } else { | ||
| const parent = path.dirname(nodePath); | ||
| if (parent in this.directories) { | ||
| // const matchingChild = this.directories[parent].children.filter(x => x.path === nodePath).first(); |
ascobie
reviewed
Aug 30, 2017
|
|
||
| for (let file of files.toArray()) { | ||
| const node = fileToTreeNode(file); | ||
|
|
Member
There was a problem hiding this comment.
probably remove these newlines to be consistent. (just between the const declarations)
ascobie
approved these changes
Aug 30, 2017
Member
ascobie
left a comment
ascobie
left a comment
There was a problem hiding this comment.
approved with a couple of non-important suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #614
This remove the file page as all the file preview are now inline. This should reduce the number of clicks
Task output new design
