Skip to content

Feature: Display message when node is unavailable to view files #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timotheeguerin merged 4 commits into from
Nov 17, 2017
Merged

Feature: Display message when node is unavailable to view files #877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c01466
Display message when node files are unavailable
timotheeguerin Nov 17, 2017
ee0f9b2
Use set
timotheeguerin Nov 17, 2017
17d423d
Use set
timotheeguerin Nov 17, 2017
1181e0b
Use set
timotheeguerin Nov 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions app/components/file/browse/node-file-browse.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import { Component, Input, OnChanges, OnDestroy } from "@angular/core";

import { FileExplorerConfig } from "app/components/file/browse/file-explorer";
import { Node } from "app/models";
import { Node, NodeState } from "app/models";
import { FileService } from "app/services";
import { FileLoader, FileNavigator } from "app/services/file";
import "./node-file-browse.scss";

export interface Folder {
name: string;
friendlyName: string;
}
const availableStates = new Set([
NodeState.idle, NodeState.running, NodeState.waitingForStartTask,
]);

/**
* Component for browsing node files.
*/
Expand All @@ -27,17 +27,21 @@ export class NodeFileBrowseComponent implements OnChanges, OnDestroy {
@Input() public folder: string = "";
@Input() public fileExplorerConfig: FileExplorerConfig;

public isNodeAvailable: boolean = false;
public fileNavigator: FileNavigator;
public pickedFileLoader: FileLoader;

constructor(private fileService: FileService) { }

public ngOnChanges(inputs) {
if (inputs.node) {
this.isNodeAvailable = availableStates.has(this.node.state);
}

if (inputs.poolId || inputs.nodeId || inputs.folder) {
this._clearFileNavigator();

if (this.poolId && this.nodeId) {

this.fileNavigator = this.fileService.navigateNodeFiles(this.poolId, this.nodeId, {
basePath: this.folder,
});
Expand Down
6 changes: 5 additions & 1 deletion app/components/file/browse/node-file-browse.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
<bl-file-explorer [data]="fileNavigator" [config]="fileExplorerConfig" *ngIf="fileNavigator">
<bl-file-explorer [data]="fileNavigator" [config]="fileExplorerConfig" *ngIf="isNodeAvailable && fileNavigator">
</bl-file-explorer>
<div *ngIf="!isNodeAvailable" class="info-overlay node-unavailable">
Node is currently
<span class="highlight">{{node.state}}&nbsp;</span>there is no files to view now.
</div>