Feature: Inbound endpoints support#993
Merged
Merged
Conversation
…ure/inbountNATPools
… component, html and related module declaration.
-added validation checks whether checking front end port range overlap or not -added validation checks name/backendPort uniqueness
- added network security rules validation
- added endpoint name regex validation - added validation of security group rules with maximum number 25
…lude itself in edit mode - updated some comment and added inboundNatPool property in creat pool model
…ne configuration property
-added a missing validation for network security group rules (compare priority with others)
…ure/inbountNATPools
timotheeguerin
changed the title
timotheeguerin
changed the title
| @@ -9,5 +9,8 @@ export class EditableTableColumnComponent { | |||
|
|
|||
| @Input() public type: string = "text"; | |||
Member
There was a problem hiding this comment.
Can you make this type to be an enum(with string values)
| @Input() public type: string = "text"; | ||
|
|
||
| /** Select options when type is 'select' */ | ||
| @Input() public select: string[]; |
Member
There was a problem hiding this comment.
I would call that options maybe
|
|
||
| public validate(c: FormControl) { | ||
| const valid = this.form.valid; | ||
| if (!valid) { |
Member
There was a problem hiding this comment.
if(valid) {return null;}?
| @Input() public inboundNATPools: InboundNATPool[]; | ||
|
|
||
| public InboundEndpointProtocol = InboundEndpointProtocol; | ||
| public minPort = EndpointHelper.MININUM_PORT; |
Member
There was a problem hiding this comment.
can't you just pass the EndpointHelper here instead of all those values, also I feel like we don't really name our constant ALL_CAPS so not sure if we should keep it like that
timotheeguerin
approved these changes
Dec 21, 2017
-fixed a bug in create job container setting validator not reset if switching from container pool to a non-container pool
| return row; | ||
| } | ||
|
|
||
| public trackIndex(index, row: any) { |
Member
There was a problem hiding this comment.
here actually you could try by the item as it's an option of type string. should be more efficient(Though doesn't really matter here as its small list that doesn't get updated)
Contributor
Author
There was a problem hiding this comment.
I will use trackRows which is already defined above.
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
==========================================
+ Coverage 54.5% 54.53% +0.02%
==========================================
Files 749 751 +2
Lines 17738 17799 +61
Branches 2008 2021 +13
==========================================
+ Hits 9668 9706 +38
- Misses 8070 8093 +23
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #965
-added pool endpoint configuration in create pool form
-fixed a bug in job container setting validators not being reset