Conversation
- CODEOWNERS with team ownership - Dependabot for NuGet, Actions, and npm - Issue templates (bug report, feature request, config) - PR template with testing checklist - CI workflow (lint + build + test, multi-OS) - copilot-instructions.md with coding conventions - CONTRIBUTING.md and CODE_OF_CONDUCT.md - .markdownlint.json configuration Closes #11
There was a problem hiding this comment.
Pull request overview
This PR adds governance, contribution, and automation scaffolding to bring Azure/Connectors-NET-LSP in line with the standards used in Azure/Connectors-NET-SDK, including repo templates, ownership, dependency automation, and a CI workflow.
Changes:
- Added repo governance artifacts (CODEOWNERS, CoC, contributing guidance, issue/PR templates, Copilot conventions, markdown lint config).
- Added Dependabot configuration for NuGet, GitHub Actions, and the VS Code extension’s npm dependencies.
- Introduced a CI workflow that lints (C# + Markdown) and runs build/test on Ubuntu and Windows.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| CONTRIBUTING.md | Adds contribution prerequisites and workflow for contributors. |
| CODE_OF_CONDUCT.md | Adds Microsoft OSS code of conduct reference. |
| .markdownlint.json | Configures markdownlint rule overrides. |
| .github/workflows/ci.yml | Adds CI pipeline for linting, building, and testing. |
| .github/pull_request_template.md | Adds PR template including testing and checklist items. |
| .github/ISSUE_TEMPLATE/feature_request.yml | Adds feature request issue template. |
| .github/ISSUE_TEMPLATE/config.yml | Configures issue creation and contact links. |
| .github/ISSUE_TEMPLATE/bug_report.yml | Adds bug report issue template. |
| .github/dependabot.yml | Enables weekly dependency update PRs with grouping. |
| .github/copilot-instructions.md | Documents coding conventions and patterns for the repo. |
| .github/CODEOWNERS | Establishes default ownership and path-specific owners. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…Settings.cs - SA1615 (return value docs) conflicts with team convention: do NOT use <returns> - SA1623 (property summary wording) too prescriptive for this codebase - SA1629 (doc ending with period) too strict for existing code - MSTestSettings.cs had UTF-8 BOM, editorconfig requires utf-8 (no BOM)
- Add blank lines around headings, code blocks, and lists (auto-fixed) - Add language specifiers to fenced code blocks (text for output/examples) - Fix broken link fragment in DEVELOPMENT_GUIDE.md - Suppress MD036 (emphasis as heading) — intentional bold text, not headings - Remove trailing whitespace
- Fix PR template link: copilot-instructions.md -> .github/copilot-instructions.md - Remove 'pinned by global.json' from CONTRIBUTING.md (no global.json exists)
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SdkIndexConstantDiscoveryTests require a Connectors SDK .nupkg in SDK/. Without it, tests now skip with Assert.Inconclusive instead of failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shore up the Azure/Connectors-NET-LSP repo to match the governance and automation standards of Azure/Connectors-NET-SDK.
Changes
Governance files
CI workflow
Repo settings (already applied via admin JIT)
Testing
Checklist
Closes #11