Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a GitHub Actions CI workflow to validate builds/tests on every PR to main and every push to main, and exposes the workflow status via a README badge.
Changes:
- Added a new
CIworkflow that runsdotnet restore/build/testonubuntu-latestandwindows-latest. - Added a packaging job that runs on Ubuntu after tests pass and uploads the produced
.nupkgas a build artifact. - Added a CI status badge to the top of the README.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Introduces PR/push validation across Ubuntu/Windows plus a gated packaging artifact job. |
README.md |
Adds a workflow status badge pointing to the new CI workflow. |
This was referenced May 7, 2026
daviburg
added a commit
that referenced
this pull request
May 7, 2026
## Summary Two codegen naming improvements (issue #114): ### 1. `.Models` Sub-namespace (#16) Move model types from the connector root namespace to a `.Models` sub-namespace: ```csharp // BEFORE - 30+ types in one namespace using Azure.Connectors.Sdk.Office365; // AFTER - client in root, models in .Models using Azure.Connectors.Sdk.Office365; using Azure.Connectors.Sdk.Office365.Models; ``` ### 2. PascalCase Client Names (#17) | Before | After | |--------|-------| | `AzureblobClient` | `AzureBlobClient` | | `MsgraphgroupsanduserClient` | `MsGraphGroupsAndUsersClient` | | `OnedriveforbusinessClient` | `OneDriveForBusinessClient` | | `SharepointonlineClient` | `SharePointOnlineClient` | ### Breaking Changes - Model types require `using {Connector}.Models;` - 4 client classes renamed to PascalCase - 4 ConnectorNames constants renamed to match - ModelFactory classes moved to `.Models` namespace ### Validation - [x] `dotnet build` - 0 errors, 0 warnings - [x] `dotnet test` - 259 passed, 0 failed ### Generator Changes BPM CodefulSdkGenerator updated in parallel (internal ADO PR) to emit these naming changes for future regeneration. Closes #114
This was referenced May 9, 2026
daviburg
added a commit
that referenced
this pull request
May 10, 2026
## Summary Implements all 5 actionable suggestions from the [v0.9 API Design Evaluation](../docs/API-DESIGN-EVALUATION-v09.md) in a single PR. ### Changes | # | Suggestion | APIView Comments Resolved | Breaking? | |---|-----------|--------------------------|-----------| | #31 | Add \(Uri, TokenCredential)\ constructor overload | 27 | No (additive) | | #32 | Make JSON converter types internal | 3 | Yes* | | #33 | \ConnectorHttpClient\ virtual + mocking constructor | 2 | No (additive) | | #34 | PascalCase client names (\AzureMonitorLogsClient\, \Office365UsersClient\) | — | Yes | | #35 | Make \IPageable<T>\ internal | 1 | Yes* | \* Unlikely to affect consumers — these are infrastructure types. **Total APIView comments addressed: 33** (out of 623 total; the remaining 590 are sync-variant/return-type/generic-name comments that are Skip decisions per the evaluation). ### Details **#31 — Constructor overload (27 comments)** Added \(Uri, TokenCredential)\ constructor to \ConnectorClientBase\ and all 12 generated clients. The Azure SDK guideline requires a constructor without \ClientOptions\ as the last parameter. **#32 — JSON converter types (3 comments)** Changed \Iso8601DateTimeConverter\, \Iso8601TimeSpanConverter\, \NullableTimeSpanConverter\ from \public\ to \internal\. These are serialization infrastructure used by \[JsonConverter]\ attributes on generated models. **#33 — ConnectorHttpClient mockability (2 comments)** Added \protected ConnectorHttpClient()\ parameterless constructor and marked \SendAsync\ as \ irtual\. Completes the mockability story — all SDK types now support mocking. **#34 — Client name PascalCase (continuation of v0.8 #17)** - \AzuremonitorlogsClient\ → \AzureMonitorLogsClient\ - \Office365usersClient\ → \Office365UsersClient\ - Updated namespaces, DI extensions, ConnectorNames constants, and test files. **#35 — IPageable\<T\> internal (1 comment)** Changed \IPageable<T>\ from \public\ to \internal\. Generated clients already return \AsyncPageable<T>\ (from Azure.Core) publicly. \IPageable<T>\ is now an internal deserialization contract only. Changed \CreatePageable\ from \protected\ to \private protected\ to match. ### Test Results All 274 tests pass. Fixes #123, #124, #125, #126, #127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a CI workflow that builds and tests on every PR and push to main, plus a build status badge in README.
Changes
Design Decisions
Follow-up
Closes #5