Add generated typed client for Azure Data Explorer (Kusto) connector#37
Merged
Conversation
- Add KustoExtensions.cs generated from BPM CodefulSdkGenerator - Add Kusto constant to ConnectorNames.cs and ManagedConnectors.cs - Add 14 unit tests for KustoClient - Update ROADMAP.md with Kusto as Phase 3.0 Complete Closes #9
There was a problem hiding this comment.
Pull request overview
Adds a new generated DirectClient connector implementation for Azure Data Explorer (Kusto) to the SDK, along with unit tests and small registry/documentation updates so the connector is discoverable in-code.
Changes:
- Added generated
KustoClient+ request/response models (including[DynamicSchema]support). - Registered
kustoin connector name constants and the available-connectors list. - Added a new
KustoClientTeststest suite and updatedROADMAP.mdto mark ADX as complete.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/Microsoft.Azure.Connectors.Sdk/Generated/KustoExtensions.cs |
New generated typed client, models, and exception type for the Kusto connector. |
src/Microsoft.Azure.Connectors.Sdk/Generated/ConnectorNames.cs |
Adds ConnectorNames.Kusto constant for compile-time connector name usage. |
src/Microsoft.Azure.Connectors.Sdk/Generated/ManagedConnectors.cs |
Adds kusto to DirectClientConnectors.AvailableConnectors and updates the usage header comment. |
tests/Microsoft.Azure.Connectors.Sdk.Tests/KustoClientTests.cs |
New unit tests covering Kusto client construction, disposal, calls, error handling, and DynamicSchema behavior. |
ROADMAP.md |
Marks Kusto/ADX as complete and adds it to the phase table. |
Generator now includes internal schema discovery methods referenced by response-level x-ms-dynamic-schema. This ensures the LSP can resolve [DynamicSchema] attributes at design time. - Kusto: adds ListKustoResultsSchemaPostAsync (7 methods total, was 6) - SharePoint: adds GetItemChangesMetadata discovery method - Teams: adds 17 schema/metadata discovery methods - Office365: unchanged (no response-level dynamic schema)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add generated typed C# client for the Azure Data Explorer (Kusto) connector, closing #9.
Changes
[DynamicSchema]onRowtype for runtime schema discoveryKustoClientwith full auth, disposal, and error handlingKustoconstantkustotoAvailableConnectors[DynamicSchema]attribute verificationGenerator fix (BPM side)
Discovered and fixed a bug where connectors with
[DynamicSchema]on response types but no[DynamicValues]or triggers were missing theusing Microsoft.Azure.Connectors.Sdkimport. Fix pushed to BPM PR 15290716.Validation