Add OneDrive for Business connector client (Tier 1)#47
Conversation
- Generated OnedriveforbusinessExtensions.cs with 22 operations: file CRUD, metadata, content, sharing links, thumbnails, copy, move, convert, search, folder listing, archive extraction - Added trigger payloads and operation constants for 4 triggers - Updated ConnectorNames.cs with Onedriveforbusiness constant - Updated ManagedConnectors.cs with onedriveforbusiness registration - Added OnedriveforbusinessClientTests.cs with full test coverage - Updated ROADMAP.md status and change log - Updated connection-setup skill with new connector name Closes #39 (SDK portion)
There was a problem hiding this comment.
Pull request overview
Adds the OneDrive for Business DirectClient connector to the SDK, wiring it into the connector registry and documenting availability, with a companion test suite to validate basic client behavior and model serialization.
Changes:
- Added generated OneDrive for Business client (
OnedriveforbusinessClient) + typed models and trigger payload types. - Registered the connector in
ConnectorNamesandDirectClientConnectors.AvailableConnectors. - Added unit tests for constructor/Dispose behavior, error handling, and JSON serialization round-trips; updated roadmap + connection setup skill docs.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Microsoft.Azure.Connectors.Sdk.Tests/OnedriveforbusinessClientTests.cs | Adds test coverage for the generated client (constructor/Dispose, mocked call, exception behavior, JSON serialization). |
| src/Microsoft.Azure.Connectors.Sdk/Generated/OnedriveforbusinessExtensions.cs | Introduces the generated OneDrive for Business DirectClient implementation (actions, triggers, models, exception type). |
| src/Microsoft.Azure.Connectors.Sdk/Generated/ManagedConnectors.cs | Registers onedriveforbusiness in the available connectors list and usage header comment. |
| src/Microsoft.Azure.Connectors.Sdk/Generated/ConnectorNames.cs | Adds the Onedriveforbusiness connector name constant for compile-time usage. |
| ROADMAP.md | Updates status/tier and logs the addition in the changelog. |
| .github/skills/connection-setup/SKILL.md | Adds onedriveforbusiness to the supported connector names list for connection setup automation. |
Comments suppressed due to low confidence (1)
.github/skills/connection-setup/SKILL.md:60
- The “Supported SDK connector names” line was updated, but the example inline comment below still omits
onedriveforbusiness(it only lists office365/sharepointonline/teams). Update the example list to include the new connector so readers don’t miss it.
Supported SDK connector names: `office365`, `onedriveforbusiness`, `sharepointonline`, `teams` (and any `Microsoft.Web/connections` connector name).
```powershell
$connectorName = "<connector-name>" # e.g., "office365", "sharepointonline", "teams"
$connectionName = "<connection-name>" # e.g., "office365-test", "sharepoint-test"
- Add onedriveforbusiness to the example connector names in SKILL.md - Add OneDrive for Business row to README validated connectors table
Address Copilot review: set StatusCode = HttpStatusCode.OK explicitly in GetFileMetadataAsync success test for clarity.
|
By design. The 4 constants in
The doc comments already distinguish them: constants with a |
Summary
Add the OneDrive for Business connector client to the SDK (Tier 1 priority).
Closes #39 (SDK portion). Samples repo work tracked in Azure/Connectors-NET-Samples#15.
Changes
Generated Code
SDK Registration
Onedriveforbusinessconstantonedriveforbusinessto available connectors list + usage exampleTests
Documentation
onedriveforbusinessto supported connector listValidation
ConnectorNames_AllConstantsAreRegistered)[DynamicSchema]types in this connector (no schema discovery operations)