Fix CI fuzzer restore isolation, pack versioning consistency, and NuGet push branch gating#5
Closed
Copilot wants to merge 2 commits into
Closed
Fix CI fuzzer restore isolation, pack versioning consistency, and NuGet push branch gating#5Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Merged
…h gating Co-authored-by: mkrueger <341098+mkrueger@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add GitHub workflows for building
Fix CI fuzzer restore isolation, pack versioning consistency, and NuGet push branch gating
Mar 20, 2026
Contributor
|
duplicate #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent correctness issues in the GitHub Actions and Azure Pipelines CI configuration identified in code review.
Changes
ci.yml– fuzzer smoke test: Added--no-restoretodotnet runso the step can't silently re-restore using the defaultnuget.config(ADO feed) instead of.github/nuget.github.config.package-unsigned.yml– pack versioning: Removed--no-buildfromdotnet packand addedVersion,FileVersion, andInformationalVersionproperties. Previously the pack reused binaries from the unversionedBuild solutionstep, producing packages where the NuGet package version differed from the embedded assembly version.CosmosDB-Shell-Official.yml– version normalization: Added$buildNumber = $versionafter theupdatebuildnumbercall so$infoVersionis constructed from the normalized version rather than the originalBuild.BuildNumber.CosmosDB-Shell-Official.yml– NuGet push gating: Changed both push step conditions fromsucceeded()toand(succeeded(), eq(variables['Build.SourceBranch'], 'refs/heads/main'))to prevent packages being pushed from feature or PR branches.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.