Merged
Conversation
cataggar
approved these changes
Apr 10, 2026
Member
cataggar
left a comment
There was a problem hiding this comment.
Overall this is a clean, well-structured .NET 10 upgrade. CI is green. Approving with two minor notes:
What looks good:
- Major version bump to 3.0.0 is appropriate for the TFM breaking change
- Central Package Management (CPM) with
CentralPackageTransitivePinningEnabledis the right approach for reproducible builds global.jsonwithrollForward: latestPatchis a good balance between pinning and flexibility- CI workflow correctly uses
global-json-fileinstead of a hardcodeddotnet-version— single source of truth - All dependency versions are explicitly pinned in
Directory.Packages.props
Minor nits (non-blocking):
-
PR description vs implementation: The description mentions "solution lock file" but the actual mechanism is CPM with transitive pinning — not a NuGet lock file (
packages.lock.json/RestorePackagesWithLockFile). The CPM approach is arguably better, but the description could be clarified. -
OpenTelemetry.Extensions.Hostingat1.0.0-rc9.5: This pre-release version is pre-existing, but worth checking if a stable release is available now given all the other deps were bumped.
cataggar
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.