move update_current_secure_channel_state before reporting attest the key#260
Merged
ZhidongPeng merged 1 commit intoAzure:devfrom Jul 25, 2025
Merged
move update_current_secure_channel_state before reporting attest the key#260ZhidongPeng merged 1 commit intoAzure:devfrom
ZhidongPeng merged 1 commit intoAzure:devfrom
Conversation
huiminyan2017
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a race condition bug, when key_latched and all provisioned, GPA starts the status reporting async task (some other telemetry async tasks too), and then update the secure channel state into shared state. There is a risk, status reporting task could get the current_secure_channel_state from shared state earlier than GPA updated it.
Hence there will be 1 minutes delay our status reporting task to get the updated current_secure_channel_state.