Conversation
rgardler-msft
previously requested changes
Jul 3, 2025
github-project-automation
bot
moved this from 🆕 Backlog
to 📋 To Do
in Innovation Engine Backlog
Collaborator
|
For context this was a TODO item I left in my PoC for Terraform docs. It was necessary to ad a "cd workingDirectory` at the start of every exec block, which is clutter. This patch removes that need. |
Member
|
LGTM, but could you add unit tests for this fix? |
aamini7
had a problem deploying
to
ScenarioTesting
GitHub Actions
Failure
aamini7
had a problem deploying
to
ScenarioTesting
GitHub Actions
Failure
aamini7
had a problem deploying
to
ScenarioTesting
GitHub Actions
Failure
vmarcella
approved these changes
Jul 23, 2025
aamini7
dismissed
rgardler-msft’s stale review
Unrelated to current PR. Making the temp file platform independent doesnt make sense since we're so coupled to bash already. It was also already like that before. Also using an ENV variable makes sense but I wasn't able to make it work because of the complex interaction of how we manage env variables
github-project-automation
bot
moved this from 📋 To Do
to ✅ Done
in Innovation Engine Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it so that the CWD is preserved between runs similar to how it is for ENV variables