-
Notifications
You must be signed in to change notification settings - Fork 95
chore(designer): Remove ParseWithMetadata filter exp flag #8640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | |
| Commit Type | ✅ | |
| Risk Level | ✅ | |
| What & Why | Slightly expand context in the explanation | |
| Impact of Change | Add System: N/A or clarify if no impact |
|
| Test Plan | ✅ | |
| Contributors | Tag others if they contributed | |
| Screenshots/Videos | ✅ |
The PR meets all required criteria and passes! Please make minor improvements to the What & Why and Impact of Change sections for clarity, if convenient, but this is not blocking. Thank you for maintaining quality standards!
Last updated: Thu, 04 Dec 2025 21:02:49 GMT
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | |
| Commit Type | ✅ | |
| Risk Level | ✅ | |
| What & Why | Optionally add a sentence about the history/impact of this flag removal | |
| Impact of Change | Fill out 'System' field explicitly as 'No architectural impact' | |
| Test Plan | ✅ | |
| Contributors | Tag or comment on contributor section if missing | |
| Screenshots/Videos | ✅ |
Your PR passes. For very high standards, consider adding a brief note on "Why now?" in the 'What & Why' and explicitly mark 'System' in Impact. Thank you for maintaining great hygiene in your PR templates!
Last updated: Thu, 04 Dec 2025 21:02:49 GMT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the ParseWithMetadata experiment flag, making the parsedocumentwithmetadata operation permanently available in the designer UI. The change eliminates conditional feature toggling that was previously controlled via experimentation flags.
Key changes:
- Removed the experiment flag definition and enablement function from the shared services
- Eliminated the hook that checked the flag state in both designer and designer-v2 libraries
- Simplified operation search and filtering logic to no longer conditionally hide the operation
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| libs/logic-apps-shared/src/designer-client-services/lib/experimentationFlags.ts | Removed ENABLE_PARSE_DOCUMENT_WITH_METADATA flag constant and enableParseDocumentWithMetadata() function |
| libs/designer/src/lib/ui/panel/recommendation/searchView.tsx | Removed hook usage and flag parameter from DefaultSearchOperationsService constructor |
| libs/designer/src/lib/ui/panel/recommendation/operationGroupDetailView.tsx | Removed hook usage and conditional filtering logic based on the flag |
| libs/designer/src/lib/ui/panel/recommendation/hooks.ts | Removed useShouldEnableParseDocumentWithMetadata hook implementation |
| libs/designer/src/lib/ui/panel/recommendation/SearchOpeationsService.tsx | Removed showParseDocWithMetadata constructor parameter and filtering logic |
| libs/designer-v2/src/lib/ui/panel/recommendation/searchView.tsx | Removed hook usage and flag parameter from DefaultSearchOperationsService constructor |
| libs/designer-v2/src/lib/ui/panel/recommendation/hooks.ts | Removed useShouldEnableParseDocumentWithMetadata hook implementation |
| libs/designer-v2/src/lib/ui/panel/recommendation/details/connectorDetailsView.tsx | Removed hook usage and conditional filtering logic based on the flag |
| libs/designer-v2/src/lib/ui/panel/recommendation/SearchOpeationsService.tsx | Removed showParseDocWithMetadata constructor parameter and filtering logic |
Commit Type
Risk Level
What & Why
Removing ParseWithMetadata Experiment Flags
Impact of Change
Test Plan
Contributors
@Eric-B-Wu
Screenshots/Videos