Skip to content

fix(mcp): update MCP Server UI copy, add dark-mode icon, add copy-URL action and tests#8755

Merged
preetriti1 merged 2 commits intohotfix/v5.262from
priti/mcpcp1
Jan 30, 2026
Merged

fix(mcp): update MCP Server UI copy, add dark-mode icon, add copy-URL action and tests#8755
preetriti1 merged 2 commits intohotfix/v5.262from
priti/mcpcp1

Conversation

@preetriti1
Copy link
Contributor

@preetriti1 preetriti1 commented Jan 30, 2026

… copy-URL action, and tests (#8752)

fix(mcp): Updating styling and content changes from review and minor design updates

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

What: "Update MCP Server UI copy and accessible labels, add dark-mode SVG icon pair and dark-mode support, add copy-URL functionality and tests, and tweak a hostConfig enabled check to better handle undefined values."
Why: "Improve UX and accessibility for MCP server flows, support dark mode icons, fix copy/clipboard behaviour, and add unit coverage for trigger detection."

Impact of Change

Users: Updated UI copy and accessible labels; dark-mode icon will display properly in dark theme; "Copy URL" button now copies endpoints to clipboard; a few toast messages changed (create/update/delete server wording).
Developers: New/changed intl ids and strings; McpServerDataProvider now accepts isDarkMode and dispatches setDarkMode (added to mcpOptions slice) — audit other call sites of McpServerDataProvider to ensure no breaking changes. New helper isHttpRequestTrigger was added and used — review any logic relying on previous trigger detection. Added/changed component props (FieldSectionItem/SectionLabel accept cssOverrides) — check other consumers.
System: Added small assets (two SVGs). Minor behavior change in WorkflowAndArtifacts conditional that could change when hostConfig is updated — confirm intended semantics and any downstream effects.

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@bonicaayala

Screenshots/Videos

… copy-URL action, and tests (#8752)

fix(mcp): Updating styling and content changes from review and minor design updates

Co-authored-by: Priti Sambandam <psamband@microsoft.com>
@preetriti1 preetriti1 added the risk:low Low risk change with minimal impact label Jan 30, 2026
@github-actions
Copy link

github-actions bot commented Jan 30, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(mcp): update MCP Server UI copy, add dark-mode icon, add copy-URL action and tests
  • Issue: None — title is concise and follows conventional commit style. It clearly describes the scope (mcp) and main changes (UI copy, dark-mode icon, copy-URL action, tests).
  • Recommendation: (Optional) Consider keeping capitalization consistent for UI labels in the title if you prefer (e.g., "MCP server" vs "MCP Server"). The current title is fine.

Commit Type

  • Properly selected (fix).
  • Note: Only one commit type is selected in the PR body which is correct.

Risk Level

  • Assessment: The PR modifies UI copy, localization strings, adds dark/light SVG assets, minor behavior tweaks (hostConfig check), adds clipboard copy functionality, and updates & adds unit tests across components.
  • Advised risk: risk:medium — this aligns with the PR's selected label and is appropriate given the number of files changed and user-facing behavior changes (UI copy, dark mode, copy-to-clipboard) plus state changes (mcpOptions slice).

What & Why

  • Current: "Update MCP Server UI copy and accessible labels, add dark-mode SVG icon pair and dark-mode support, add copy-URL functionality and tests, and tweak a hostConfig enabled check to better handle undefined values." / "Improve UX and accessibility for MCP server flows, support dark mode icons, fix copy/clipboard behaviour, and add unit coverage for trigger detection."
  • Issue: None — concise and explains the motivation.
  • Recommendation: (Optional) You may add a one-line note if any backend or deployment coordination is required (there do not appear to be backend changes in this PR).

Impact of Change

  • Impact section present and maps to code changes.
  • Recommendation: Keep the audit note about McpServerDataProvider isDarkMode usage (you already mentioned to audit call sites). If possible, call out the store slice addition (isDarkMode) in the Developers section explicitly (you already reference it, which is good).
    • Users: Updated UI copy and accessible labels; dark-mode icon will display properly in dark theme; "Copy URL" button now copies endpoints to clipboard; wording of a few toasts updated.
    • Developers: New/changed intl ids and strings; McpServerDataProvider now accepts isDarkMode and dispatches setDarkMode (added to mcpOptions slice) — audit other call sites of McpServerDataProvider to ensure no breaking changes. New helper isHttpRequestTrigger was added and used — review any logic relying on previous trigger detection. FieldSectionItem/SectionLabel accept cssOverrides — check other consumers.
    • System: Added small assets (two SVGs). Minor behavior change in WorkflowAndArtifacts conditional (hostConfig truthiness check) — calls out a possible subtle change in semantics which you already documented.

Test Plan

  • Assessment: Good. The PR body marks Unit tests added/updated and Manual testing completed.
  • Validation: The diff shows unit test additions/updates (new tests for isHttpRequestTrigger, many updated component tests, and other spec changes). E2E tests were not added and the PR body does not claim E2E coverage — acceptable for this change.
  • Recommendation: Ensure CI runs all new/updated test suites (they appear present in the diff). If there are flaky tests (not observed here), add notes.

Contributors

  • Assessment: Contributors listed (@bonicaayala). Good.
  • Recommendation: If others contributed (design/PM/review), consider tagging them in the PR body to give credit.

⚠️ Screenshots/Videos

  • Assessment: None provided. This is optional — no visual regression expected other than icon and copy changes. If you want design sign-off, consider adding screenshots of the empty-state and dark-mode icon in both themes.

Summary Table

Section Status Recommendation
Title Title is clear and follows conventional commit style.
Commit Type Commit type selected correctly (fix).
Risk Level risk:medium is appropriate and matches labels.
What & Why Good brief description and motivation.
Impact of Change Good coverage of user/dev/system impact.
Test Plan Unit tests added/updated and manual testing done; CI should run them.
Contributors Contributor listed; consider adding additional reviewers if applicable.
Screenshots/Videos ⚠️ Optional: consider screenshots for UI/dark-mode preview.

Final message
Everything in the PR title and body aligns with the changes in the diff. The risk label on the PR is risk:medium, which matches my advised risk level of medium. Unit tests are present/updated in the diff, and there is a clear Test Plan. No blocking issues found in the PR description or title.

Suggested small improvements (optional):

  • Add a short screenshot of the empty-state and the dark-mode icon in both themes to make visual review easier for designers (optional).
  • Double-check any other call sites of McpServerDataProvider to ensure adding the isDarkMode param doesn’t cause TypeScript or runtime issues in consumers (you already mentioned auditing this; please ensure all call sites still type-check).
  • Confirm CI runs and passes the new tests; if any tests are intentionally skipped (I noticed a couple of skipped tests in the test updates), add a short explanation for why they are skipped and how/when they will be enabled.

Please update if you'd like help drafting a more explicit changelog entry for these user-facing copy changes. Thanks for the thorough PR — looks good to merge once CI is green!


Last updated: Fri, 30 Jan 2026 03:48:34 GMT

@preetriti1 preetriti1 added risk:medium Medium risk change with potential impact and removed needs-pr-update risk:low Low risk change with minimal impact labels Jan 30, 2026
@preetriti1 preetriti1 changed the title fix(mcp): update MCP server UI copy/text, add dark-mode icon support,… fix(mcp): update MCP Server UI copy, add dark-mode icon, add copy-URL action and tests Jan 30, 2026
@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

….spec.ts (#8736)

fix: remove getAgentBaseUrl tests from config-parser.spec.ts
@preetriti1 preetriti1 enabled auto-merge (squash) January 30, 2026 03:48
@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@preetriti1 preetriti1 merged commit 5f4c34d into hotfix/v5.262 Jan 30, 2026
10 checks passed
@preetriti1 preetriti1 deleted the priti/mcpcp1 branch January 30, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants