fix(mcp): update MCP Server UI copy, add dark-mode icon, add copy-URL action and tests#8755
Merged
preetriti1 merged 2 commits intohotfix/v5.262from Jan 30, 2026
Merged
fix(mcp): update MCP Server UI copy, add dark-mode icon, add copy-URL action and tests#8755preetriti1 merged 2 commits intohotfix/v5.262from
preetriti1 merged 2 commits intohotfix/v5.262from
Conversation
… copy-URL action, and tests (#8752) fix(mcp): Updating styling and content changes from review and minor design updates Co-authored-by: Priti Sambandam <psamband@microsoft.com>
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | Title is clear and follows conventional commit style. |
| Commit Type | ✅ | Commit type selected correctly (fix). |
| Risk Level | ✅ | risk:medium is appropriate and matches labels. |
| What & Why | ✅ | Good brief description and motivation. |
| Impact of Change | ✅ | Good coverage of user/dev/system impact. |
| Test Plan | ✅ | Unit tests added/updated and manual testing done; CI should run them. |
| Contributors | ✅ | Contributor listed; consider adding additional reviewers if applicable. |
| Screenshots/Videos | Optional: consider screenshots for UI/dark-mode preview. |
Final message
Everything in the PR title and body aligns with the changes in the diff. The risk label on the PR is risk:medium, which matches my advised risk level of medium. Unit tests are present/updated in the diff, and there is a clear Test Plan. No blocking issues found in the PR description or title.
Suggested small improvements (optional):
- Add a short screenshot of the empty-state and the dark-mode icon in both themes to make visual review easier for designers (optional).
- Double-check any other call sites of McpServerDataProvider to ensure adding the isDarkMode param doesn’t cause TypeScript or runtime issues in consumers (you already mentioned auditing this; please ensure all call sites still type-check).
- Confirm CI runs and passes the new tests; if any tests are intentionally skipped (I noticed a couple of skipped tests in the test updates), add a short explanation for why they are skipped and how/when they will be enabled.
Please update if you'd like help drafting a more explicit changelog entry for these user-facing copy changes. Thanks for the thorough PR — looks good to merge once CI is green!
Last updated: Fri, 30 Jan 2026 03:48:34 GMT
|
📊 Coverage check completed. See workflow run for details. |
….spec.ts (#8736) fix: remove getAgentBaseUrl tests from config-parser.spec.ts
takyyon
approved these changes
Jan 30, 2026
|
📊 Coverage check completed. See workflow run for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… copy-URL action, and tests (#8752)
fix(mcp): Updating styling and content changes from review and minor design updates
Commit Type
Risk Level
What & Why
What: "Update MCP Server UI copy and accessible labels, add dark-mode SVG icon pair and dark-mode support, add copy-URL functionality and tests, and tweak a hostConfig enabled check to better handle undefined values."
Why: "Improve UX and accessibility for MCP server flows, support dark mode icons, fix copy/clipboard behaviour, and add unit coverage for trigger detection."
Impact of Change
Users: Updated UI copy and accessible labels; dark-mode icon will display properly in dark theme; "Copy URL" button now copies endpoints to clipboard; a few toast messages changed (create/update/delete server wording).
Developers: New/changed intl ids and strings; McpServerDataProvider now accepts isDarkMode and dispatches setDarkMode (added to mcpOptions slice) — audit other call sites of McpServerDataProvider to ensure no breaking changes. New helper isHttpRequestTrigger was added and used — review any logic relying on previous trigger detection. Added/changed component props (FieldSectionItem/SectionLabel accept cssOverrides) — check other consumers.
System: Added small assets (two SVGs). Minor behavior change in WorkflowAndArtifacts conditional that could change when hostConfig is updated — confirm intended semantics and any downstream effects.
Test Plan
Contributors
@bonicaayala
Screenshots/Videos